Skip to content

cmake: support local installations of git #3814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2022
Merged

cmake: support local installations of git #3814

merged 1 commit into from
Apr 22, 2022

Conversation

carenas
Copy link

@carenas carenas commented Apr 21, 2022 •
edited
Loading

At least in systems where the user is local and not an administrator
git will install in a subdirectory of %APPDATALOCAL%, so it makes
sense to also look there for the shell needed by the cmake integration
with Visual Studio.

@carenas
cmake: support local installations of git
187f5e4 
At least in systems where the user is local and not an administrator
git will install in a subdirectory of %APPDATALOCAL%, so it makes
sense to also look there for the shell needed by the cmake integration
with Visual Studio.
dscho
dscho approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I do not want to encourage user-only installations (we had too many problems with multiple installations on the same machine), this change seems to be benign enough.

@dscho dscho merged commit fbb7027 into git-for-windows:main Apr 22, 2022
@dscho
Copy link
Member

dscho commented Apr 22, 2022

Since you contributed this patch here, I assume you want me to upstream it. If that is the case, can I assume your Sign-off, @carenas?

@carenas carenas deleted the appdata branch April 22, 2022 09:10
dscho added a commit that referenced this pull request Apr 26, 2022
@dscho
Merge pull request #3814 from carenas/appdata
2fbbb35 
cmake: support local installations of git
dscho added a commit that referenced this pull request Apr 26, 2022
@dscho
Merge pull request #3814 from carenas/appdata
f2315c2 
cmake: support local installations of git
dscho added a commit that referenced this pull request Apr 26, 2022
@dscho
Merge pull request #3814 from carenas/appdata
248c5f7 
cmake: support local installations of git
dscho added a commit that referenced this pull request Apr 26, 2022
@dscho
Merge pull request #3814 from carenas/appdata
037a5a9 
cmake: support local installations of git
dscho added a commit that referenced this pull request Apr 28, 2022
@dscho
Merge pull request #3814 from carenas/appdata
1b2db34 
cmake: support local installations of git
dscho added a commit that referenced this pull request Apr 28, 2022
@dscho
Merge pull request #3814 from carenas/appdata
fa52863 
cmake: support local installations of git
dscho added a commit that referenced this pull request Apr 28, 2022
@dscho
Merge pull request #3814 from carenas/appdata
abe08a1 
cmake: support local installations of git
dscho added a commit that referenced this pull request Apr 29, 2022
@dscho
Merge pull request #3814 from carenas/appdata
a6c178f 
cmake: support local installations of git
dscho added a commit that referenced this pull request Apr 29, 2022
@dscho
Merge pull request #3814 from carenas/appdata
e6ce223 
cmake: support local installations of git
dscho added a commit that referenced this pull request Apr 29, 2022
@dscho
Merge pull request #3814 from carenas/appdata
cf99e9a 
cmake: support local installations of git
dscho added a commit that referenced this pull request Apr 29, 2022
@dscho
Merge pull request #3814 from carenas/appdata
1751c94 
cmake: support local installations of git
dscho added a commit that referenced this pull request Apr 29, 2022
@dscho
Merge pull request #3814 from carenas/appdata
c879f40 
cmake: support local installations of git
dscho added a commit that referenced this pull request May 2, 2022
@dscho
Merge pull request #3814 from carenas/appdata
9dc090d 
cmake: support local installations of git
dscho added a commit that referenced this pull request May 3, 2022
@dscho
Merge pull request #3814 from carenas/appdata
44d2d12 
cmake: support local installations of git
dscho added a commit that referenced this pull request May 3, 2022
@dscho
Merge pull request #3814 from carenas/appdata
8ce5ad6 
cmake: support local installations of git
dscho added a commit that referenced this pull request May 3, 2022
@dscho
Merge pull request #3814 from carenas/appdata
d4beeab 
cmake: support local installations of git
dscho added a commit that referenced this pull request May 5, 2022
@dscho
Merge pull request #3814 from carenas/appdata
4f1d22c 
cmake: support local installations of git
dscho added a commit that referenced this pull request May 5, 2022
@dscho
Merge pull request #3814 from carenas/appdata
b9a04a0 
cmake: support local installations of git
dscho added a commit that referenced this pull request May 5, 2022
@dscho
Merge pull request #3814 from carenas/appdata
6c29aa3 
cmake: support local installations of git
dscho added a commit that referenced this pull request May 9, 2022
@dscho
Merge pull request #3814 from carenas/appdata
2bec125 
cmake: support local installations of git
dscho added a commit that referenced this pull request May 9, 2022
@dscho
Merge pull request #3814 from carenas/appdata
b0dab26 
cmake: support local installations of git
dscho added a commit that referenced this pull request May 9, 2022
@dscho
Merge pull request #3814 from carenas/appdata
80e778c 
cmake: support local installations of git
dscho added a commit that referenced this pull request May 9, 2022
@dscho
Merge pull request #3814 from carenas/appdata
3b985f3 
cmake: support local installations of git
dscho added a commit to dscho/git that referenced this pull request May 9, 2022
@dscho
Merge pull request git-for-windows#3814 from carenas/appdata
2744b1d 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request May 9, 2022
@dscho
Merge pull request #3814 from carenas/appdata
6f173c4 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 22, 2022
@dscho
Merge pull request #3814 from carenas/appdata
01e66ca 
cmake: support local installations of git
dscho added a commit that referenced this pull request Jul 25, 2022
@dscho
Merge pull request #3814 from carenas/appdata
effd102 
cmake: support local installations of git
dscho added a commit that referenced this pull request Jul 25, 2022
@dscho
Merge pull request #3814 from carenas/appdata
de99281 
cmake: support local installations of git
dscho added a commit that referenced this pull request Jul 25, 2022
@dscho
Merge pull request #3814 from carenas/appdata
7524966 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 25, 2022
@dscho
Merge pull request #3814 from carenas/appdata
76a6082 
cmake: support local installations of git
dscho added a commit that referenced this pull request Jul 25, 2022
@dscho
Merge pull request #3814 from carenas/appdata
cedce9b 
cmake: support local installations of git
dscho added a commit that referenced this pull request Jul 25, 2022
@dscho
Merge pull request #3814 from carenas/appdata
140cc6d 
cmake: support local installations of git
dscho added a commit that referenced this pull request Jul 25, 2022
@dscho
Merge pull request #3814 from carenas/appdata
b76ec54 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 25, 2022
@dscho
Merge pull request #3814 from carenas/appdata
0bfb840 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 25, 2022
@dscho
Merge pull request #3814 from carenas/appdata
23ea355 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 25, 2022
@dscho
Merge pull request #3814 from carenas/appdata
430612f 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 25, 2022
@dscho
Merge pull request #3814 from carenas/appdata
7c3478a 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 26, 2022
@dscho
Merge pull request #3814 from carenas/appdata
9be6799 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 26, 2022
@dscho
Merge pull request #3814 from carenas/appdata
6876fe7 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 26, 2022
@dscho
Merge pull request #3814 from carenas/appdata
c894adb 
cmake: support local installations of git
dscho added a commit that referenced this pull request Jul 26, 2022
@dscho
Merge pull request #3814 from carenas/appdata
76bb120 
cmake: support local installations of git
dscho added a commit that referenced this pull request Jul 28, 2022
@dscho
Merge pull request #3814 from carenas/appdata
402d0c6 
cmake: support local installations of git
dscho added a commit that referenced this pull request Jul 28, 2022
@dscho
Merge pull request #3814 from carenas/appdata
c51c1f2 
cmake: support local installations of git
dscho added a commit that referenced this pull request Jul 28, 2022
@dscho
Merge pull request #3814 from carenas/appdata
6e49d38 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 28, 2022
@dscho
Merge pull request #3814 from carenas/appdata
67aa07c 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 29, 2022
@dscho
Merge pull request #3814 from carenas/appdata
0da7424 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 29, 2022
@dscho
Merge pull request #3814 from carenas/appdata
c3a2307 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Jul 29, 2022
@dscho
Merge pull request #3814 from carenas/appdata
29ee60d 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Aug 1, 2022
@dscho
Merge pull request #3814 from carenas/appdata
cbf7039 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Aug 3, 2022
@dscho
Merge pull request #3814 from carenas/appdata
c32f7b3 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Aug 5, 2022
@dscho
Merge pull request #3814 from carenas/appdata
3bdb356 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Aug 5, 2022
@dscho
Merge pull request #3814 from carenas/appdata
6f8d003 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Aug 11, 2022
@dscho
Merge pull request #3814 from carenas/appdata
8ced5cc 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Aug 12, 2022
@dscho
Merge pull request #3814 from carenas/appdata
5c4947f 
cmake: support local installations of git
git-for-windows-ci pushed a commit that referenced this pull request Aug 14, 2022
@dscho
Merge pull request #3814 from carenas/appdata
e29590b 
cmake: support local installations of git
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscho dscho dscho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carenas @dscho