Skip to content

Commit ac81f7d

Browse files
dschoGit for Windows Build Agent
dscho
authored and
Git for Windows Build Agent
committed
Merge pull request #2506 from dscho/issue-2283
Allow running Git directly from `C:\Program Files\Git\mingw64\bin\git.exe`
2 parents b5c3821 + 86ad393 commit ac81f7d

File tree

3 files changed

+131
-4
lines changed

3 files changed

+131
-4
lines changed

‎compat/mingw.c

Lines changed: 97 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2903,6 +2903,66 @@ int xwcstoutf(char *utf, const wchar_t *wcs, size_t utflen)
29032903
return -1;
29042904
}
29052905

2906+
#ifdef ENSURE_MSYSTEM_IS_SET
2907+
#if !defined(RUNTIME_PREFIX) || !defined(HAVE_WPGMPTR)
2908+
static size_t append_system_bin_dirs(char *path UNUSED, size_t size UNUSED)
2909+
{
2910+
return 0;
2911+
}
2912+
#else
2913+
static size_t append_system_bin_dirs(char *path, size_t size)
2914+
{
2915+
char prefix[32768];
2916+
const char *slash;
2917+
size_t len = xwcstoutf(prefix, _wpgmptr, sizeof(prefix)), off = 0;
2918+
2919+
if (len == 0 || len >= sizeof(prefix) ||
2920+
!(slash = find_last_dir_sep(prefix)))
2921+
return 0;
2922+
/* strip trailing `git.exe` */
2923+
len = slash - prefix;
2924+
2925+
/* strip trailing `cmd` or `mingw64\bin` or `mingw32\bin` or `bin` or `libexec\git-core` */
2926+
if (strip_suffix_mem(prefix, &len, "\\mingw64\\libexec\\git-core") ||
2927+
strip_suffix_mem(prefix, &len, "\\mingw64\\bin"))
2928+
off += xsnprintf(path + off, size - off,
2929+
"%.*s\\mingw64\\bin;", (int)len, prefix);
2930+
else if (strip_suffix_mem(prefix, &len, "\\clangarm64\\libexec\\git-core") ||
2931+
strip_suffix_mem(prefix, &len, "\\clangarm64\\bin"))
2932+
off += xsnprintf(path + off, size - off,
2933+
"%.*s\\clangarm64\\bin;", (int)len, prefix);
2934+
else if (strip_suffix_mem(prefix, &len, "\\mingw32\\libexec\\git-core") ||
2935+
strip_suffix_mem(prefix, &len, "\\mingw32\\bin"))
2936+
off += xsnprintf(path + off, size - off,
2937+
"%.*s\\mingw32\\bin;", (int)len, prefix);
2938+
else if (strip_suffix_mem(prefix, &len, "\\cmd") ||
2939+
strip_suffix_mem(prefix, &len, "\\bin") ||
2940+
strip_suffix_mem(prefix, &len, "\\libexec\\git-core"))
2941+
off += xsnprintf(path + off, size - off,
2942+
"%.*s\\mingw%d\\bin;", (int)len, prefix,
2943+
(int)(sizeof(void *) * 8));
2944+
else
2945+
return 0;
2946+
2947+
off += xsnprintf(path + off, size - off,
2948+
"%.*s\\usr\\bin;", (int)len, prefix);
2949+
return off;
2950+
}
2951+
#endif
2952+
#endif
2953+
2954+
static int is_system32_path(const char *path)
2955+
{
2956+
WCHAR system32[MAX_PATH], wpath[MAX_PATH];
2957+
2958+
if (xutftowcs_path(wpath, path) < 0 ||
2959+
!GetSystemDirectoryW(system32, ARRAY_SIZE(system32)) ||
2960+
_wcsicmp(system32, wpath))
2961+
return 0;
2962+
2963+
return 1;
2964+
}
2965+
29062966
static void setup_windows_environment(void)
29072967
{
29082968
char *tmp = getenv("TMPDIR");
@@ -2943,7 +3003,8 @@ static void setup_windows_environment(void)
29433003
strbuf_addstr(&buf, tmp);
29443004
if ((tmp = getenv("HOMEPATH"))) {
29453005
strbuf_addstr(&buf, tmp);
2946-
if (is_directory(buf.buf))
3006+
if (!is_system32_path(buf.buf) &&
3007+
is_directory(buf.buf))
29473008
setenv("HOME", buf.buf, 1);
29483009
else
29493010
tmp = NULL; /* use $USERPROFILE */
@@ -2954,6 +3015,41 @@ static void setup_windows_environment(void)
29543015
if (!tmp && (tmp = getenv("USERPROFILE")))
29553016
setenv("HOME", tmp, 1);
29563017
}
3018+
3019+
if (!getenv("PLINK_PROTOCOL"))
3020+
setenv("PLINK_PROTOCOL", "ssh", 0);
3021+
3022+
#ifdef ENSURE_MSYSTEM_IS_SET
3023+
if (!(tmp = getenv("MSYSTEM")) || !tmp[0]) {
3024+
const char *home = getenv("HOME"), *path = getenv("PATH");
3025+
char buf[32768];
3026+
size_t off = 0;
3027+
3028+
#if defined(__aarch64__) || defined(_M_ARM64) || defined(_M_ARM64EC)
3029+
setenv("MSYSTEM", "CLANGARM64", 1);
3030+
#elif defined(__MINGW64__) || defined(_M_AMD64)
3031+
setenv("MSYSTEM", "MINGW64", 1);
3032+
#else
3033+
setenv("MSYSTEM", "MINGW32", 1);
3034+
#endif
3035+
3036+
if (home)
3037+
off += xsnprintf(buf + off, sizeof(buf) - off,
3038+
"%s\\bin;", home);
3039+
off += append_system_bin_dirs(buf + off, sizeof(buf) - off);
3040+
if (path)
3041+
off += xsnprintf(buf + off, sizeof(buf) - off,
3042+
"%s", path);
3043+
else if (off > 0)
3044+
buf[off - 1] = '\0';
3045+
else
3046+
buf[0] = '\0';
3047+
setenv("PATH", buf, 1);
3048+
}
3049+
#endif
3050+
3051+
if (!getenv("LC_ALL") && !getenv("LC_CTYPE") && !getenv("LANG"))
3052+
setenv("LC_CTYPE", "C.UTF-8", 1);
29573053
}
29583054

29593055
static void get_current_user_sid(PSID *sid, HANDLE *linked_token)

‎config.mak.uname

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ endif
512512
compat/win32/pthread.o compat/win32/syslog.o \
513513
compat/win32/trace2_win32_process_info.o \
514514
compat/win32/dirent.o
515-
COMPAT_CFLAGS = -D__USE_MINGW_ACCESS -DDETECT_MSYS_TTY -DNOGDI -DHAVE_STRING_H -Icompat -Icompat/regex -Icompat/win32 -DSTRIP_EXTENSION=\".exe\"
515+
COMPAT_CFLAGS = -D__USE_MINGW_ACCESS -DDETECT_MSYS_TTY -DENSURE_MSYSTEM_IS_SET -DNOGDI -DHAVE_STRING_H -Icompat -Icompat/regex -Icompat/win32 -DSTRIP_EXTENSION=\".exe\"
516516
BASIC_LDFLAGS = -IGNORE:4217 -IGNORE:4049 -NOLOGO -ENTRY:wmainCRTStartup -SUBSYSTEM:CONSOLE
517517
# invalidcontinue.obj allows Git's source code to close the same file
518518
# handle twice, or to access the osfhandle of an already-closed stdout
@@ -745,7 +745,7 @@ ifeq ($(uname_S),MINGW)
745745
endif
746746
CC = gcc
747747
COMPAT_CFLAGS += -D__USE_MINGW_ANSI_STDIO=0 -DDETECT_MSYS_TTY \
748-
-fstack-protector-strong
748+
-DENSURE_MSYSTEM_IS_SET -fstack-protector-strong
749749
EXTLIBS += -lntdll
750750
EXTRA_PROGRAMS += headless-git$X
751751
INSTALL = /bin/install

‎t/t0060-path-utils.sh

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,8 @@ test_expect_success !VALGRIND,RUNTIME_PREFIX,CAN_EXEC_IN_PWD 'RUNTIME_PREFIX wor
610610
echo "echo HERE" | write_script pretend/libexec/git-core/git-here &&
611611
GIT_EXEC_PATH= ./pretend/bin/git here >actual &&
612612
echo HERE >expect &&
613-
test_cmp expect actual'
613+
test_cmp expect actual
614+
'
614615

615616
test_expect_success !VALGRIND,RUNTIME_PREFIX,CAN_EXEC_IN_PWD '%(prefix)/ works' '
616617
git config yes.path "%(prefix)/yes" &&
@@ -619,4 +620,34 @@ test_expect_success !VALGRIND,RUNTIME_PREFIX,CAN_EXEC_IN_PWD '%(prefix)/ works'
619620
test_cmp expect actual
620621
'
621622

623+
test_expect_success MINGW,RUNTIME_PREFIX 'MSYSTEM/PATH is adjusted if necessary' '
624+
if test -z "$MINGW_PREFIX"
625+
then
626+
MINGW_PREFIX="/$(echo "${MSYSTEM:-MINGW64}" | tr A-Z a-z)"
627+
fi &&
628+
mkdir -p "$HOME"/bin pretend"$MINGW_PREFIX"/bin \
629+
pretend"$MINGW_PREFIX"/libexec/git-core pretend/usr/bin &&
630+
cp "$GIT_EXEC_PATH"/git.exe pretend"$MINGW_PREFIX"/bin/ &&
631+
cp "$GIT_EXEC_PATH"/git.exe pretend"$MINGW_PREFIX"/libexec/git-core/ &&
632+
# copy the .dll files, if any (happens when building via CMake)
633+
if test -n "$(ls "$GIT_EXEC_PATH"/*.dll 2>/dev/null)"
634+
then
635+
cp "$GIT_EXEC_PATH"/*.dll pretend"$MINGW_PREFIX"/bin/ &&
636+
cp "$GIT_EXEC_PATH"/*.dll pretend"$MINGW_PREFIX"/libexec/git-core/
637+
fi &&
638+
echo "env | grep MSYSTEM=" | write_script "$HOME"/bin/git-test-home &&
639+
echo "echo ${MINGW_PREFIX#/}" | write_script pretend"$MINGW_PREFIX"/bin/git-test-bin &&
640+
echo "echo usr" | write_script pretend/usr/bin/git-test-bin2 &&
641+
642+
(
643+
MSYSTEM= &&
644+
GIT_EXEC_PATH= &&
645+
pretend"$MINGW_PREFIX"/libexec/git-core/git.exe test-home >actual &&
646+
pretend"$MINGW_PREFIX"/libexec/git-core/git.exe test-bin >>actual &&
647+
pretend"$MINGW_PREFIX"/bin/git.exe test-bin2 >>actual
648+
) &&
649+
test_write_lines MSYSTEM=$MSYSTEM "${MINGW_PREFIX#/}" usr >expect &&
650+
test_cmp expect actual
651+
'
652+
622653
test_done

0 commit comments

Comments
 (0)