Skip to content

Commit 02ca044

Browse files
dschoGit for Windows Build Agent
authored and
Git for Windows Build Agent
committed
Merge pull request #797 from glhez/master
`git bundle create <bundle>` leaks handle the revlist is empty.
2 parents 2d9cc2c + e598039 commit 02ca044

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

bundle.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -457,10 +457,11 @@ int create_bundle(struct bundle_header *header, const char *path,
457457
object_array_remove_duplicates(&revs.pending);
458458

459459
ref_count = write_bundle_refs(bundle_fd, &revs);
460-
if (!ref_count)
461-
die(_("Refusing to create empty bundle."));
462-
else if (ref_count < 0)
460+
if (ref_count <= 0) {
461+
if (!ref_count)
462+
error(_("Refusing to create empty bundle."));
463463
goto err;
464+
}
464465

465466
/* write pack */
466467
if (write_pack_data(bundle_fd, &revs)) {

t/t5607-clone-bundle.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,4 +71,8 @@ test_expect_success 'prerequisites with an empty commit message' '
7171
git bundle verify bundle
7272
'
7373

74+
test_expect_success 'try to create a bundle with empty ref count' '
75+
test_expect_code 1 git bundle create foobar.bundle master..master
76+
'
77+
7478
test_done

0 commit comments

Comments
 (0)