Exclude Windows Server 2016 from WAM support #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows Server 2016 does not support WAM, so we should not try to enable the broker unless we're on Server 2019 and later. Also update the Windows (client; non-server) version checks to be tighter. Previously any major version of 10 or greater was considered "supported", but this is wrong. Windows 10 build 15063 was the first to support WAM.
mjcheetham
added
bug
mjcheetham
requested review from
dscho,
derrickstolee,
vdye,
jeffhostetler and
ldennington
jeffhostetler
approved these changes
Mar 1, 2022
derrickstolee
approved these changes
Mar 1, 2022
|
cc @bgavrilMS |
|
Not sure you need to go to all this trouble, we fixed this in MSAL itself. |
The problem is that |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows Server 2016 does not support WAM, so we should not try to enable the broker unless we're on Server 2019 and later.
Also update the Windows (client; non-server) version checks to be tighter. Previously any major version of 10 or greater was considered "supported", but this is wrong. Windows 10 build 15063 was the first to support WAM.
Fixes #487