Override MSAL's system webview handling#2258
Merged
mjcheetham merged 1 commit intogit-ecosystem:mainfrom Feb 5, 2026
Merged
Conversation
Contributor
Author
|
This depends on this other PR completing first. |
mjcheetham
force-pushed
the
msal-webview-detect
branch
2 times, most recently
from
76fe22c to
3f8de8b
Compare
mjcheetham
force-pushed
the
msal-webview-detect
branch
from
3f8de8b to
5ac2e50
Compare
dscho
approved these changes
Feb 5, 2026
Contributor
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
This makes sense to me, especially with that excellent commit message, thanks!
mjcheetham
force-pushed
the
msal-webview-detect
branch
from
5ac2e50 to
1b9d51a
Compare
Since we have special handling on Linux (eg WSL support), we try to use our own logic for launching the user's default web browser for interactive authentication. In the event we fail to start the browser, we fall back to using MSAL's logic, with a preference of Edge (Chromium-based) - largely because this is the only way to hook ourselves back into MSAL's default handling. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
mjcheetham
force-pushed
the
msal-webview-detect
branch
from
1b9d51a to
77f109c
Compare
Merged
mjcheetham
added a commit
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have special handling on Linux (eg WSL support), we try to use our own logic for launching the user's default web browser for interactive authentication.
In the event we fail to start the browser, we fall back to using MSAL's logic, with a preference of Edge (Chromium-based) - largely because this is the only way to hook ourselves back into MSAL's default handling.