Skip to content

Commit 143ef0c

Browse files
ldenningtonldennington
committed
trace2: add region infrastructure
Add supporting infrastructure for regions. This includes the normal `Write` methods in Trace2 and corresponding Trace2 messages with a few notable distinctions: 1. There is an abstract parent RegionMessage that inherits from Trace2Message. The RegionEnterMessage and RegionLeave messages inherit from this parent (rather than Trace2Message) to maximize reuse of shared fields. 2. We create a new Region class that implements DisposableObject and call it using a CreateRegion method in Trace2. This ensures that we call WriteRegionLeave before a Region object is disposed - a key requirement of Git's Trace2 API for regions. Additionally, it allows us to manage getting the executing thread name and region timings within the class, thus removing this burden from consumers. An additional note is that the region_enter and region_leave events will always have the same line number with this model. This was deemed to be acceptable, however, given that knowing where a region begins executing provides enough information for inspection of the region if it is needed.
1 parent ed3a115 commit 143ef0c

File tree

3 files changed

+267
-13
lines changed

3 files changed

+267
-13
lines changed

‎src/shared/Core/Trace2.cs‎

Lines changed: 147 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ public enum Trace2Event
1919
ChildStart = 3,
2020
ChildExit = 4,
2121
Error = 5,
22+
RegionEnter = 6,
23+
RegionLeave = 7,
2224
}
2325

2426
/// <summary>
@@ -54,6 +56,40 @@ public class PerformanceFormatSpan
5456
public int EndPadding { get; set; }
5557
}
5658

59+
/// <summary>
60+
/// Class that manages regions.
61+
/// </summary>
62+
public class Region : DisposableObject
63+
{
64+
private readonly ITrace2 _trace2;
65+
private readonly string _category;
66+
private readonly string _label;
67+
private readonly string _filePath;
68+
private readonly int _lineNumber;
69+
private readonly string _message;
70+
private readonly DateTimeOffset _startTime;
71+
72+
public Region(ITrace2 trace2, string category, string label, string filePath, int lineNumber, string message = "")
73+
{
74+
_trace2 = trace2;
75+
_category = category;
76+
_label = label;
77+
_filePath = filePath;
78+
_lineNumber = lineNumber;
79+
_message = message;
80+
81+
_startTime = DateTimeOffset.UtcNow;
82+
83+
_trace2.WriteRegionEnter(_category, _label, _message, _filePath, _lineNumber);
84+
}
85+
86+
protected override void ReleaseManagedResources()
87+
{
88+
double relativeTime = (DateTimeOffset.UtcNow - _startTime).TotalSeconds;
89+
_trace2.WriteRegionLeave(relativeTime, _category, _label, _message, _filePath, _lineNumber);
90+
}
91+
}
92+
5793
/// <summary>
5894
/// Represents the application's TRACE2 tracing system.
5995
/// </summary>
@@ -141,6 +177,59 @@ void WriteError(
141177
string filePath = "",
142178
[System.Runtime.CompilerServices.CallerLineNumber]
143179
int lineNumber = 0);
180+
181+
/// <summary>
182+
/// Creates a region and manages entry/leaving.
183+
/// </summary>
184+
/// <param name="category">Category of region.</param>
185+
/// <param name="label">Description of region.</param>
186+
/// <param name="message">Message associated with entering region.</param>
187+
/// <param name="filePath">Path of the file this method is called from.</param>
188+
/// <param name="lineNumber">Line number of file this method is called from.</param>
189+
Region CreateRegion(
190+
string category,
191+
string label,
192+
string message = "",
193+
[System.Runtime.CompilerServices.CallerFilePath]
194+
string filePath = "",
195+
[System.Runtime.CompilerServices.CallerLineNumber]
196+
int lineNumber = 0);
197+
198+
/// <summary>
199+
/// Writes a region enter message to the trace writer.
200+
/// </summary>
201+
/// <param name="category">Category of region.</param>
202+
/// <param name="label">Description of region.</param>
203+
/// <param name="message">Message associated with entering region.</param>
204+
/// <param name="filePath">Path of the file this method is called from.</param>
205+
/// <param name="lineNumber">Line number of file this method is called from.</param>
206+
void WriteRegionEnter(
207+
string category,
208+
string label,
209+
string message = "",
210+
[System.Runtime.CompilerServices.CallerFilePath]
211+
string filePath = "",
212+
[System.Runtime.CompilerServices.CallerLineNumber]
213+
int lineNumber = 0);
214+
215+
/// <summary>
216+
/// Writes a region leave message to the trace writer.
217+
/// </summary>
218+
/// <param name="relativeTime">Time of region execution.</param>
219+
/// <param name="category">Category of region.</param>
220+
/// <param name="label">Description of region.</param>
221+
/// <param name="message">Message associated with entering region.</param>
222+
/// <param name="filePath">Path of the file this method is called from.</param>
223+
/// <param name="lineNumber">Line number of file this method is called from.</param>
224+
void WriteRegionLeave(
225+
double relativeTime,
226+
string category,
227+
string label,
228+
string message = "",
229+
[System.Runtime.CompilerServices.CallerFilePath]
230+
string filePath = "",
231+
[System.Runtime.CompilerServices.CallerLineNumber]
232+
int lineNumber = 0);
144233
}
145234

146235
public class Trace2 : DisposableObject, ITrace2
@@ -309,6 +398,64 @@ public void WriteError(
309398
});
310399
}
311400

401+
public Region CreateRegion(
402+
string category,
403+
string label,
404+
string message,
405+
string filePath,
406+
int lineNumber)
407+
{
408+
return new Region(this, category, label, filePath, lineNumber, message);
409+
}
410+
411+
public void WriteRegionEnter(
412+
string category,
413+
string label,
414+
string message = "",
415+
string filePath = "",
416+
int lineNumber = 0)
417+
{
418+
WriteMessage(new RegionEnterMessage()
419+
{
420+
Event = Trace2Event.RegionEnter,
421+
Sid = _sid,
422+
Time = DateTimeOffset.UtcNow,
423+
Category = category,
424+
Label = label,
425+
Message = message == "" ? label : message,
426+
Thread = BuildThreadName(),
427+
File = Path.GetFileName(filePath),
428+
Line = lineNumber,
429+
ElapsedTime = (DateTimeOffset.UtcNow - _applicationStartTime).TotalSeconds,
430+
Depth = ProcessManager.Depth
431+
});
432+
}
433+
434+
public void WriteRegionLeave(
435+
double relativeTime,
436+
string category,
437+
string label,
438+
string message = "",
439+
string filePath = "",
440+
int lineNumber = 0)
441+
{
442+
WriteMessage(new RegionLeaveMessage()
443+
{
444+
Event = Trace2Event.RegionLeave,
445+
Sid = _sid,
446+
Time = DateTimeOffset.UtcNow,
447+
Category = category,
448+
Label = label,
449+
Message = message == "" ? label : message,
450+
Thread = BuildThreadName(),
451+
File = Path.GetFileName(filePath),
452+
Line = lineNumber,
453+
ElapsedTime = (DateTimeOffset.UtcNow - _applicationStartTime).TotalSeconds,
454+
RelativeTime = relativeTime,
455+
Depth = ProcessManager.Depth
456+
});
457+
}
458+
312459
protected override void ReleaseManagedResources()
313460
{
314461
lock (_writersLock)

‎src/shared/Core/Trace2Message.cs‎

Lines changed: 95 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,7 @@
77

88
namespace GitCredentialManager;
99

10-
public interface ITrace2Message
11-
{
12-
Trace2Event Event { get; set; }
13-
string Sid { get; set; }
14-
string Thread { get; set; }
15-
DateTimeOffset Time { get; set; }
16-
string File { get; set; }
17-
int Line { get; set; }
18-
int Depth { get; set; }
19-
}
20-
21-
public abstract class Trace2Message : ITrace2Message
10+
public abstract class Trace2Message
2211
{
2312
private const int SourceColumnMaxWidth = 23;
2413
private const string NormalPerfTimeFormat = "HH:mm:ss.ffffff";
@@ -173,7 +162,8 @@ private static string BuildSpan(PerformanceFormatSpan component, string data)
173162

174163
if (data.Length < dataLimit)
175164
{
176-
component.EndPadding += Math.Abs(sizeDifference);
165+
// Increase end padding for short values
166+
component.EndPadding += sizeDifference;
177167
}
178168

179169
var beginPadding = new string(' ', component.BeginPadding);
@@ -447,3 +437,95 @@ protected override string GetEventMessage(Trace2FormatTarget formatTarget)
447437
return Message;
448438
}
449439
}
440+
441+
public abstract class RegionMessage : Trace2Message
442+
{
443+
[JsonProperty("repo")]
444+
445+
// Defaults to 1, as does Git.
446+
// See https://git-scm.com/docs/api-trace2#Documentation/technical/api-trace2.txt-codeltrepo-idgtcode for details.
447+
public int Repo { get; set; } = 1;
448+
449+
// TODO: Remove default value if support for nested regions is implemented.
450+
[JsonProperty("nesting")]
451+
public int Nesting { get; set; } = 1;
452+
453+
[JsonProperty("category")]
454+
public string Category { get; set; }
455+
456+
[JsonProperty("label")]
457+
public string Label { get; set; }
458+
459+
[JsonProperty("msg")]
460+
public string Message { get; set; }
461+
462+
public double ElapsedTime { get; set; }
463+
}
464+
465+
public class RegionEnterMessage : RegionMessage
466+
{
467+
public override string ToJson()
468+
{
469+
return JsonConvert.SerializeObject(this,
470+
new StringEnumConverter(typeof(SnakeCaseNamingStrategy)),
471+
new IsoDateTimeConverter()
472+
{
473+
DateTimeFormat = TimeFormat
474+
});
475+
}
476+
477+
public override string ToNormalString()
478+
{
479+
return BuildNormalString();
480+
}
481+
482+
public override string ToPerformanceString()
483+
{
484+
return BuildPerformanceString();
485+
}
486+
487+
protected override string BuildPerformanceSpan()
488+
{
489+
return $"|{BuildRepoSpan(Repo)}|{BuildTimeSpan(ElapsedTime)}| |{BuildCategorySpan(Category)}";
490+
}
491+
492+
protected override string GetEventMessage(Trace2FormatTarget formatTarget)
493+
{
494+
return Message;
495+
}
496+
}
497+
498+
public class RegionLeaveMessage : RegionMessage
499+
{
500+
public double RelativeTime { get; set; }
501+
502+
public override string ToJson()
503+
{
504+
return JsonConvert.SerializeObject(this,
505+
new StringEnumConverter(typeof(SnakeCaseNamingStrategy)),
506+
new IsoDateTimeConverter()
507+
{
508+
DateTimeFormat = TimeFormat
509+
});
510+
}
511+
512+
public override string ToNormalString()
513+
{
514+
return BuildNormalString();
515+
}
516+
517+
public override string ToPerformanceString()
518+
{
519+
return BuildPerformanceString();
520+
}
521+
522+
protected override string BuildPerformanceSpan()
523+
{
524+
return $"|{BuildRepoSpan(Repo)}|{BuildTimeSpan(ElapsedTime)}|{BuildTimeSpan(RelativeTime)}|{BuildCategorySpan(Category)}";
525+
}
526+
527+
protected override string GetEventMessage(Trace2FormatTarget formatTarget)
528+
{
529+
return Message;
530+
}
531+
}

‎src/shared/TestInfrastructure/Objects/NullTrace.cs‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,31 @@ public void WriteError(
8484
string filePath = "",
8585
int lineNumber = 0) { }
8686

87+
public Region CreateRegion(
88+
string category,
89+
string label,
90+
string message = "",
91+
string filePath = "",
92+
int lineNumber = 0)
93+
{
94+
return new Region(this, category, label, filePath, lineNumber, message);
95+
}
96+
97+
public void WriteRegionEnter(
98+
string category,
99+
string label,
100+
string message = "",
101+
string filePath = "",
102+
int lineNumber = 0) { }
103+
104+
public void WriteRegionLeave(
105+
double relativeTime,
106+
string category,
107+
string label,
108+
string message = "",
109+
string filePath = "",
110+
int lineNumber = 0) { }
111+
87112
#endregion
88113

89114
#region IDisposable

0 commit comments

Comments
 (0)