Bug fixes on the game

Author: giocalitri

New/hangman.js

@@ -236,7 +236,7 @@ function hide_keyboard_letters(hangman_var)
 	var let_guess = hangman_var['curgame']['letter_guessed'];
 	for (lett in let_guess)
 	{
-		document.getElementById("let_"+lett).className += " hideletter";
+		document.getElementById("let_"+lett).className = "hideletter";
 	}
 }
 //function that shows all the letters in the keyboard 
@@ -252,6 +252,18 @@ function show_keyboard_letters()
 	}
 }
 
+//function that checks if a letter has been already used
+function is_alredy_guessed_letter(letter, hangman_var)
+{
+	var let_guess = hangman_var['curgame']['letter_guessed'];
+	for (var guessed in let_guess)
+	{
+		if (guessed == letter)
+			return true;
+	}
+	return false;	
+}
+
 //function that shos the hangman image given the current guesses remaining and the difficulty level
 function show_img(hangman_var)
 {
@@ -286,7 +298,7 @@ function show_img(hangman_var)
 	{
 		var oImg=document.createElement("img");
 		oImg.setAttribute('src', 'img/'+img_to_show);
-		oImg.setAttribute('alt', ('Remaining chances: '+rem_chances));
+		oImg.setAttribute('alt', ('Image for remaining chances: '+rem_chances));
 		oImg.setAttribute('height', '150');
 		oImg.setAttribute('width', '75');
 		var imgID = document.getElementById("cur_img");
@@ -345,47 +357,50 @@ function start_new_game()
 //function that guesses a letter
 function guess_letter(lett)
 {
-	if (HANGMAN['curgame']['rem_chances'] > 0)
+	if (! is_alredy_guessed_letter(lett, HANGMAN))
 	{
-		//I update the status of the game if necessary
-		if (!HANGMAN['curgame']['game_started'])
-			HANGMAN['curgame']['game_started'] = true;
-		
-		//In any case I add the leter to the global variable
-		HANGMAN['curgame']['letter_guessed'][lett] = true;
-		
-		//I get the word to find
-		var word = HANGMAN['curgame']['word'];
-		//I check if there are some instances of the current letter in the word
-		var positions = letter_in_word(lett, word);
-		//If I have at least one position, then I found a letter in the word 
-		//and I have to check if all the word has been revealed
-		if (positions.length >0)
+		if (HANGMAN['curgame']['rem_chances'] > 0)
 		{
-			//check if all the word has been revealed
-			if (is_word_complete(HANGMAN))
+			//I update the status of the game if necessary
+			if (!HANGMAN['curgame']['game_started'])
+				HANGMAN['curgame']['game_started'] = true;
+			
+			//In any case I add the leter to the global variable
+			HANGMAN['curgame']['letter_guessed'][lett] = true;
+			
+			//I get the word to find
+			var word = HANGMAN['curgame']['word'];
+			//I check if there are some instances of the current letter in the word
+			var positions = letter_in_word(lett, word);
+			//If I have at least one position, then I found a letter in the word 
+			//and I have to check if all the word has been revealed
+			if (positions.length >0)
 			{
-				//I update the stats
-				HANGMAN['played'] = HANGMAN['played'] + 1;
-				HANGMAN['won'] = HANGMAN['won'] + 1;
-				HANGMAN['curgame']['game_status'] = 'won';
+				//check if all the word has been revealed
+				if (is_word_complete(HANGMAN))
+				{
+					//I update the stats
+					HANGMAN['played'] = HANGMAN['played'] + 1;
+					HANGMAN['won'] = HANGMAN['won'] + 1;
+					HANGMAN['curgame']['game_status'] = 'won';
+				}
 			}
-		}
-		//Otherwise I have to reduce the future changes and check if this was the last one!
-		else
-		{
-			HANGMAN['curgame']['rem_chances'] = HANGMAN['curgame']['rem_chances'] -1;
-			if (HANGMAN['curgame']['rem_chances'] == 0)
+			//Otherwise I have to reduce the future changes and check if this was the last one!
+			else
 			{
-				//I update the stats
-				HANGMAN['played'] += 1;
-				HANGMAN['curgame']['game_status'] = 'lost';
+				HANGMAN['curgame']['rem_chances'] = HANGMAN['curgame']['rem_chances'] -1;
+				if (HANGMAN['curgame']['rem_chances'] == 0)
+				{
+					//I update the stats
+					HANGMAN['played'] += 1;
+					HANGMAN['curgame']['game_status'] = 'lost';
+				}
 			}
+			//I save the new variable in the localStorage
+			save_to_localstorage('HANGMAN', HANGMAN);
+			//and I show the current situation
+			show_cur_game(HANGMAN);
 		}
-		//I save the new variable in the localStorage
-		save_to_localstorage('HANGMAN', HANGMAN);
-		//and I show the current situation
-		show_cur_game(HANGMAN);
 	}
 }
 

New/hangman_desktop.php

@@ -26,10 +26,10 @@
 		</div>
 		<div id="setup_scores">
 			<ul class="letters">
+				<li class="newgame" onclick="start_new_game();">New game</li>
 				<li id="level_easy" onclick="change_level('easy');">Easy</li>
 				<li id="level_medium" onclick="change_level('medium');">Medium</li>
 				<li id="level_hard" onclick="change_level('hard');">Hard</li>
-				<li class="newgame" onclick="start_new_game();">New game</li>
 			</ul>
 			<ul class="scores">
 				<li>Games Played: <span id="game_played">0</span></li>
@@ -77,7 +77,6 @@
 		</ul>
 	</div>
 </div>
-<!-- <script type="text/javascript" src="jquery-1.6.4.min.js"></script> -->
 <script type="text/javascript" src="hangman.js"></script>
 </body>
 </html>

New/hangman_mobile.php

@@ -19,10 +19,13 @@
 <h1>Hangman</h1>
 <div id="container">
 	<div id="game">
-		<div id="hangman_img"></div>
+		<div id="hangman_img">
+			<div id="cur_img"></div>
+			<div id="rem_chances"></div>
+		</div>
 		<div id="setup_scores">
 			<ul class="letters">
-				<li class="newgame">New game</li>
+				<li class="newgame" onclick="start_new_game();">New game</li>
 				<li id="level_easy" onclick="change_level('easy');">Easy</li>
 				<li id="level_medium" onclick="change_level('medium');">Medium</li>
 				<li id="level_hard" onclick="change_level('hard');">Hard</li>
@@ -41,23 +44,34 @@
 		</div>
 		<div id="keyboard">
 			<ul class="letters">
-				<li>A</li><li>B</li><li>C</li><li>D</li><li>E</li><li>F</li><li>G</li><li>H</li><li>I</li><li>J</li><li>K</li><li>L</li><li>M</li>
-				<li>N</li><li>O</li><li>P</li><li>Q</li><li>R</li><li>S</li><li>T</li><li>U</li><li>V</li><li>W</li><li>X</li><li>Y</li><li>Z</li>
+				<li id="let_A" onclick="guess_letter('A');">A</li><li id="let_B" onclick="guess_letter('B');">B</li>
+				<li id="let_C" onclick="guess_letter('C');">C</li><li id="let_D" onclick="guess_letter('D');">D</li>
+				<li id="let_E" onclick="guess_letter('E');">E</li><li id="let_F" onclick="guess_letter('F');">F</li>
+				<li id="let_G" onclick="guess_letter('G');">G</li><li id="let_H" onclick="guess_letter('H');">H</li>
+				<li id="let_I" onclick="guess_letter('I');">I</li><li id="let_J" onclick="guess_letter('J');">J</li>
+				<li id="let_K" onclick="guess_letter('K');">K</li><li id="let_L" onclick="guess_letter('L');">L</li>
+				<li id="let_M" onclick="guess_letter('M');">M</li><li id="let_N" onclick="guess_letter('N');">N</li>
+				<li id="let_O" onclick="guess_letter('O');">O</li><li id="let_P" onclick="guess_letter('P');">P</li>
+				<li id="let_Q" onclick="guess_letter('Q');">Q</li><li id="let_R" onclick="guess_letter('R');">R</li>
+				<li id="let_S" onclick="guess_letter('S');">S</li><li id="let_T" onclick="guess_letter('T');">T</li>
+				<li id="let_U" onclick="guess_letter('U');">U</li><li id="let_V" onclick="guess_letter('V');">V</li>
+				<li id="let_W" onclick="guess_letter('W');">W</li><li id="let_X" onclick="guess_letter('X');">X</li>
+				<li id="let_Y" onclick="guess_letter('Y');">Y</li><li id="let_Z" onclick="guess_letter('Z');">Z</li>
 			</ul>
 		</div>
 	</div>
 	<div id="help">
 		<h2>How to play</h2>
 		<ul>
+			<li>If you want select the difficulty level. This sets the number of wrong attempts before hanging to 3, 6, or 12</li>
 			<li>Press New Game</li>
-			<li>Select the difficulty level. This sets the number of wrong attempts before hanging to 3, 6, or 12</li>
-			<li>The game begins when you select your first character</li>
+			<li>The game begins when you select your first character.</li>
 			<li>You cannot change the difficulty level once the game has started until the &quot;New Game&quot; button is pressed</li>
 		</ul>
 	</div>
 	<div id="footer">
 		<ul>
-			<li><a href="<?php echo $path_parts['dirname']?>/hangman.php?vpa=m">View mobile version of this website</a></li>
+			<li><a href="<?php echo $path_parts['dirname']?>/hangman.php?vpa=d">View desktop version of this website</a></li>
 			<li><a href="http://www.huntingground.freeserve.co.uk/main/mainfram.htm?../games/hangman/hangman1.htm">Visit the website that inspired this page</a></li>
 		</ul>
 	</div>

New/style.php

@@ -108,7 +108,8 @@
 }
 
 ul.letters li.hideletter {
-	display:none;
+	background-color:grey;
+	cursor:auto;
 }
 
 #help ul {
@@ -120,9 +121,9 @@
 	width:auto;
 }
 #setup_scores ul.letters li.newgame {
+	float:none;
 	clear: both;
-	padding-left:2em;
-	padding-right:2em;
+	width: 7em;
 }
 
 ul.scores {