-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3500 Add escape logic for header #3503
Fix #3500 Add escape logic for header #3503
Conversation
c22614f
to
bd78de0
Compare
Codecov Report
@@ Coverage Diff @@
## master #3503 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 42 42
Lines 3151 3151
=======================================
Hits 3108 3108
Misses 29 29
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bd78de0
to
fd9f98e
Compare
2deb996
to
2c2e15f
Compare
I finished the exception handling that cases I was considering.
|
2c2e15f
to
6e8f186
Compare
6e8f186
to
6b8cd84
Compare
6b8cd84
to
260f21b
Compare
Update - Initialize regular expressions only once and simplify logic |
260f21b
to
0cc8dca
Compare
Update - Test Case |
0cc8dca
to
69e306f
Compare
I have some questions in Lines 205 to 211 in e46bd52
Why the expectation of Line221 is Lines 221 to 223 in e46bd52
Additionally, is there any difference if the URL prefix returned by .Location() includes a leading slash or does not include one? |
Hi, @appleboy, @thinkerou
Excuse me, I again think about #3500
I'm sorry to bother you.
.
delimiter & Repeated/
delimiter was judged to need to be delete and merge,So, I request PR again.
alphabets
,numeric
,-
,/
)/
delimiters into one