Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use bytes.ReplaceAll directly #3455

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

lgbgbl
Copy link
Contributor

@lgbgbl lgbgbl commented Dec 31, 2022

Use bytes.ReplaceAll(name, centerDot, dot) instead of bytes.Replace(name, centerDot, dot, -1), which looks more concise

@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Merging #3455 (25fc611) into master (b2d4185) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3455   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          42       42           
  Lines        3140     3140           
=======================================
  Hits         3097     3097           
  Misses         29       29           
  Partials       14       14           
Flag Coverage Δ
98.63% <100.00%> (ø)
go-1.16 ∅ <ø> (∅)
go-1.17 98.53% <100.00%> (ø)
go-1.18 98.53% <100.00%> (ø)
go-1.19 98.63% <100.00%> (ø)
macos-latest 98.63% <100.00%> (ø)
ubuntu-latest 98.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
recovery.go 98.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@appleboy
Copy link
Member

appleboy commented Jan 1, 2023

build fail

@lgbgbl lgbgbl force-pushed the refactor/bytes-replace branch from 746ac8b to 25fc611 Compare January 20, 2023 16:04
@thinkerou thinkerou added this to the v1.10 milestone Mar 1, 2023
@thinkerou thinkerou merged commit de1c4ec into gin-gonic:master Mar 1, 2023
@thinkerou thinkerou modified the milestones: v1.10, v1.9.1 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants