Convert strings and slices using the officially recommended way #3344
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go official is expected to provide unsafe.{SliceData, Slice, StringData,
String} series methods in version 1.20 for conversion of strings and
slices.
|
This change needs to wait for the release of go1.20, please review it at that time, thank you. |
hopehook
changed the title
|
Please add a reference documentation link. |
|
please rebase the master branch. |
Codecov Report
@@ Coverage Diff @@
## master #3344 +/- ##
==========================================
+ Coverage 98.27% 98.63% +0.36%
==========================================
Files 42 42
Lines 3127 3151 +24
==========================================
+ Hits 3073 3108 +35
+ Misses 40 29 -11
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
maybe we also add reference documentation link to comment of code. |
@thinkerou Please take a look, thank you. |
appleboy
approved these changes
Feb 8, 2023
appleboy
requested changes
Feb 8, 2023
appleboy
previously approved these changes
Feb 9, 2023
thinkerou
reviewed
Mar 1, 2023
internal/bytesconv/bytesconv_1.19.go
Outdated
| @@ -2,6 +2,9 @@ | |||
| // Use of this source code is governed by a MIT style | |||
| // license that can be found in the LICENSE file. | |||
|
|
|||
| //go:build !go1.20 | |||
| // +build !go1.20 | |||
There was a problem hiding this comment.
please remove +build !go1.20, because we support min go version = 1.18
thinkerou
reviewed
Mar 1, 2023
internal/bytesconv/bytesconv_1.20.go
Outdated
| // license that can be found in the LICENSE file. | ||
|
|
||
| //go:build go1.20 | ||
| // +build go1.20 |
thinkerou
reviewed
Mar 1, 2023
thinkerou
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go official is expected to provide unsafe.{SliceData, Slice, StringData, String} series methods in version 1.20 for conversion of strings and slices.
Reference: golang/go#53003