Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed SetOutput() panics on go 1.17 #2861

Merged
merged 2 commits into from
Sep 8, 2021
Merged

fixed SetOutput() panics on go 1.17 #2861

merged 2 commits into from
Sep 8, 2021

Conversation

cookieY
Copy link
Contributor

@cookieY cookieY commented Sep 7, 2021 •
edited
Loading

updated go-isatty to v0.0.14

link: mattn/go-isatty#66

@appleboy appleboy added bug dependencies Pull requests that update a dependency file labels Sep 7, 2021
@appleboy appleboy added this to the v1.8 milestone Sep 7, 2021
@codecov
Copy link

codecov bot commented Sep 7, 2021 •
edited
Loading

Codecov Report

Merging #2861 (5500727) into master (ae349b4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2861   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          41       41           
  Lines        3060     3060           
=======================================
  Hits         3022     3022           
  Misses         26       26           
  Partials       12       12
Flag Coverage Δ
go-1.13 98.75% <ø> (+0.01%) ⬆️
go-1.14 98.59% <ø> (?)
go-1.15 98.59% <ø> (ø)
go-1.16 98.59% <ø> (ø)
go-1.17 98.49% <ø> (?)
macos-latest 98.75% <ø> (?)
nomsgpack 98.74% <ø> (ø)
ubuntu-latest 98.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae349b4...5500727. Read the comment docs.

thinkerou
thinkerou previously approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update go.sum and then lgtm, thanks!

@cookieY
Copy link
Contributor Author

cookieY commented Sep 8, 2021 •
edited
Loading

please update go.sum and then lgtm, thanks!

updated go.sum

@thinkerou thinkerou self-requested a review September 8, 2021 03:30
thinkerou
thinkerou approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thinkerou thinkerou merged commit 3a6f18f into gin-gonic:master Sep 8, 2021
Bisstocuz pushed a commit to Bisstocuz/gin that referenced this pull request Nov 22, 2021
@cookieY @Bisstocuz
fixed SetOutput() panics on go 1.17 (gin-gonic#2861)
f28a617 
* fixed SetOutput() panics on go 1.17

* update go.sum

(cherry picked from commit 3a6f18f)
daheige pushed a commit to daheige/gin that referenced this pull request Apr 18, 2022
@cookieY @daheige
fixed SetOutput() panics on go 1.17 (gin-gonic#2861)
4889aad 
* fixed SetOutput() panics on go 1.17

* update go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou thinkerou approved these changes

Assignees
No one assigned
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@cookieY @thinkerou @appleboy