-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add StaticFileFS #2749
feat: add StaticFileFS #2749
Conversation
add StaticFileFS ad README
Codecov Report
@@ Coverage Diff @@
## master #2749 +/- ##
==========================================
+ Coverage 98.69% 98.75% +0.06%
==========================================
Files 41 41
Lines 2072 3064 +992
==========================================
+ Hits 2045 3026 +981
- Misses 15 26 +11
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
improve StaticFile and StaticFileFS code, use staticFileHandler
any update? |
@thinkerou Please help to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This reverts commit 417b142.
* RouterGroup.StaticFileFS added add StaticFileFS ad README * fix Static content mistake * update README `tab` improve StaticFile and StaticFileFS code, use staticFileHandler
I was miising feature of Serving file form http.FileSystem
there has StaticFile,Static,StaticFS method, since go1.16 embed feature, I am not find how to get a file from embed fs. follow is my want
Use cases:
- Serve file by alias from
http.FileSystem