Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to support go module #1569

Merged
merged 4 commits into from
Oct 15, 2018
Merged

attempt to support go module #1569

merged 4 commits into from
Oct 15, 2018

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Sep 25, 2018

Ensure old version run right and then attempt to support go module.
please @javierprovecho @appleboy help review, thanks!

@thinkerou thinkerou changed the title test vgo use WIP: test vgo use Sep 26, 2018
@thinkerou thinkerou changed the title WIP: test vgo use WIP: attempt to use vgo Sep 26, 2018
@thinkerou thinkerou changed the title WIP: attempt to use vgo WIP: attempt to use vgo [skip ci] Sep 26, 2018
@thinkerou thinkerou closed this Sep 26, 2018
@thinkerou thinkerou reopened this Sep 26, 2018
@thinkerou thinkerou changed the title WIP: attempt to use vgo [skip ci] WIP: attempt to use vgo Sep 26, 2018
@codecov
Copy link

codecov bot commented Sep 27, 2018

Codecov Report

Merging #1569 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1569   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files          39       39           
  Lines        1928     1928           
=======================================
  Hits         1914     1914           
  Misses         10       10           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ca253...c95129a. Read the comment docs.

@thinkerou thinkerou changed the title WIP: attempt to use vgo attempt to support go module Sep 29, 2018
Makefile Outdated Show resolved Hide resolved
@thinkerou thinkerou merged commit 523435e into gin-gonic:master Oct 15, 2018
@rarkins
Copy link

rarkins commented Oct 15, 2018

Here are some other go.mod updates you could make: https://github.com/renovate-mirrors/gin/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc

image

@thinkerou
Copy link
Member Author

@rarkins thanks, some deps can upgrade now, but some deps can't.
How should I use them?

@rarkins
Copy link

rarkins commented Oct 15, 2018

@thinkerou Renovate Bot is something I wrote that can be installed into any repo, so if you wanted the PRs here then you could install it.

Otherwise, I have set up the "mirror" that will keep in sync each hour or two with this parent repo and always maintain a list of outdated dependencies in PRs for you to see. FYI, I used this repository as one of my test repositories when testing support for go modules in the bot.

If you don't want to install the bot but would like to upgrade some of the modules it suggests, you can do this:

  1. View the list of branches in the mirror: https://github.com/renovate-mirrors/gin/branches/active
  2. Click on the branch you want
  3. Click on "Compare"
  4. Click on "Create Pull Request"

GitHub should then let you raise your own PR into this repository from the branch in the mirror.

@thinkerou
Copy link
Member Author

@rarkins thanks, got it. Because gin still mainly use govendor, we need to upgrade vendor.json and then upgrade go.mod/go.sum. I will fix the issue tonight.

@thinkerou thinkerou deleted the use-vgo branch October 20, 2018 00:01
justinfx pushed a commit to justinfx/gin that referenced this pull request Nov 3, 2018
* support go module

* update golint package url

* update golint
@kidlj
Copy link

kidlj commented Dec 16, 2018

godep save . fails because of these blank imports.

$ godep save
godep: Package (github.com/client9/misspell/cmd/misspell) not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants