Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for supporting file binding #1264

Merged
merged 10 commits into from
Mar 18, 2019
Merged

update for supporting file binding #1264

merged 10 commits into from
Mar 18, 2019

Conversation

p581581
Copy link
Contributor

@p581581 p581581 commented Mar 1, 2018

update for supporting multipart form and file binding

example:

type PhoptUploadForm struct {
	imgData    *multipart.FileHeader `form:"img_data" binding:"required"`
	ProjectID   string `form:"project_id" binding:"required"`
	Description string `form:"description binding:"required"`
}

ref: #1263

@codecov
Copy link

codecov bot commented Mar 1, 2018

Codecov Report

Merging #1264 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   98.63%   98.64%   +0.01%     
==========================================
  Files          41       41              
  Lines        2124     2145      +21     
==========================================
+ Hits         2095     2116      +21     
  Misses         18       18              
  Partials       11       11
Impacted Files Coverage Δ
binding/binding.go 100% <100%> (ø) ⬆️
binding/form.go 100% <100%> (ø) ⬆️
binding/form_mapping.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcf36ad...261e496. Read the comment docs.

@p581581 p581581 force-pushed the master branch 2 times, most recently from 98c4d3f to bdc4336 Compare March 2, 2018 03:27
@thinkerou
Copy link
Member

@p581581 please fix conflict, thanks!

binding/binding.go Outdated Show resolved Hide resolved
@thinkerou thinkerou added this to the 1.4 milestone Oct 24, 2018
@thinkerou
Copy link
Member

@p581581 please fix conflict, thanks!

@thinkerou
Copy link
Member

@p581581 any updates? thanks!

@p581581
Copy link
Contributor Author

p581581 commented Feb 28, 2019

I thought this pr is closed. Give me some time to fix the conflicts.

@thinkerou
Copy link
Member

@p581581 OK, thanks! I will save the pr until you fix it.

@thinkerou thinkerou modified the milestones: 1.4, 1.x, 1.5 Feb 28, 2019
@haoguo
Copy link

haoguo commented Mar 16, 2019

any progress of this feature? really need it. I could make some contribution to this if no one do it, @thinkerou

thinkerou
thinkerou previously approved these changes Mar 17, 2019
@thinkerou thinkerou modified the milestones: 1.5, 1.4 Mar 17, 2019
@p581581
Copy link
Contributor Author

p581581 commented Mar 17, 2019

Thank you!! @thinkerou. I'm too busy to fix it, sorry about that.

@thinkerou
Copy link
Member

@appleboy please help review the pull request, thanks!

@appleboy appleboy merged commit c16bfa7 into gin-gonic:master Mar 18, 2019
@appleboy
Copy link
Member

@thinkerou maybe add an example in gin-gonic/example repo or add tips in the documentation.

@thinkerou
Copy link
Member

@appleboy OK, I add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants