upgrade validator version to v9 #1015

thinkerou · 2017-07-13T14:37:35Z

No description provided.

appleboy · 2017-07-13T14:50:28Z

build fail. missing some package.

cch123 · 2017-07-13T15:02:48Z

validator removes exists tag from v8 to v9, this update may break some users' apps

codecov · 2017-07-13T15:49:58Z

Codecov Report

Merging #1015 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1015   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          40       40           
  Lines        2225     2225           
=======================================
  Hits         2196     2196           
  Misses         16       16           
  Partials       13       13

Impacted Files	Coverage Δ
binding/default_validator.go	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f7fc3...5610fa4. Read the comment docs.

javierprovecho · 2017-07-13T16:01:47Z

Please hold this PR, need to clarify if this (#1015) and #990 should be considered breaking and need a major version bump, or a warning in the changelog is ok for a minor version bump (v1.3 milestone)

cc @tboerger @appleboy

javierprovecho · 2017-07-16T20:42:11Z

note: review #430 (comment)

ghost

Is the same example that validator provides, i add to my project and not break

ashtonian · 2018-05-01T20:39:55Z

Wondering what the status of this is - does somebody need to submit another PR?

thinkerou · 2018-05-20T01:25:28Z

@aadidenko nobody, only the pr, waiting for review.

zwhitchcox · 2018-05-21T14:37:35Z

Ok, yall, I think we need to prioritize this PR. My users need emojis in their usernames.

Ianwww · 2018-07-10T15:17:42Z

Is there another way to upgrade to v9 without waiting for this PR to get merged in?

kishaningithub · 2018-08-27T09:01:45Z

Validator V9 includes oneof validation which is very much needed for my project

tomriddle1234 · 2018-09-04T04:10:06Z

oh here it is, mark this one too

FaithOliviaTKPD · 2018-09-24T05:17:03Z

Any updates on this PR? Validator V9 would be really useful!

thinkerou · 2018-09-25T03:07:10Z

Maybe we should upgrade milestone v1.4.0, ping @javierprovecho @appleboy thanks!

rssathe · 2018-12-18T08:47:36Z

@thinkerou @appleboy can we get this merged in?

plo- · 2019-02-06T12:05:45Z

Any news?

always-waiting · 2019-02-21T03:27:46Z

Any news?

always-waiting · 2019-02-21T03:41:19Z

@thinkerou
i am forward to it~

thinkerou · 2019-02-21T03:47:37Z

@always-waiting sorry, the issue need @javierprovecho review and agree! thanks!

dmarkham · 2019-05-22T14:48:59Z

@thinkerou what are you thinking in regards to moving forward with v9? We going to merge this or reject it?

thinkerou · 2019-05-22T15:39:06Z

agree, KISS is best, gin should't not to do complex param check.

I also like KISS, about the pull request we should wait @javierprovecho review as your said #1015 (comment), upgrade to v9 isn't urgent, so we should wait his reply.

thinkerou · 2019-05-26T00:35:28Z

@appleboy we should merge to gin1.5 branch now? thanks!

TonyPythoneer · 2019-06-24T14:52:57Z

@thinkerou Please fix the conflict.

Could it release it as next versions after merging this branch?

In my view, this issue is more important than other. We desire to use the latest validation to enhance current error message readability. To compare other issues in 1.5 milestone, those are bug fix and feature enhancements. It seems it’s not critical for current gin. Those can postpone to future version. To focus simple and important issue, let the PR get merged and the new change get released fast.

In short, we hope the 1.5 or any milestone’s scope could get reduced or classify more and small task. It ensures the release can ship fast to developer.

In personal, I am very expected every new release of gin, we will use the new feature to simplify our development. Thanks.

If other gin fans have any idea, please comment here. I want to know what you expect and discuss here. Thanks.

souravray · 2019-07-19T04:10:52Z

The PR still doesn't expose the validator object.
Is there a way to access the validator object, so RegisterValidation method can be called?

Askadias · 2019-09-04T01:09:30Z

Any progress on getting this released?

appleboy · 2019-09-04T03:37:21Z

@thinkerou Please fix the conflict.

thinkerou · 2019-09-04T04:23:40Z

@appleboy done

thinkerou · 2019-09-05T12:27:33Z

As #1015 (comment) said, we need to add breaking change log and merge it now, right? @appleboy

appleboy · 2019-09-05T13:22:14Z

@thinkerou Yes, we need to write some changes like features or bug fix in CHANGELOG.md for next release version.

thinkerou · 2019-09-05T13:39:41Z

@appleboy OK, thanks! merged.

* upgrade validator version to v9 * Update vendor.json * Update go.mod * Update go.sum * fix * fix * fix bug * Update binding_test.go * Update validate_test.go * Update go.sum * Update go.mod * Update go.sum * Update go.mod * Update go.sum

upgrade validator version to v9

22b63be

javierprovecho added this to the 1.x milestone Jul 13, 2017

javierprovecho added enhancement need-review labels Jul 16, 2017

sudo-suhas mentioned this pull request Nov 17, 2017

Custom Binding Error Message #430

Closed

ghost reviewed Jan 8, 2018

View reviewed changes

thinkerou mentioned this pull request Mar 8, 2018

Update validator to version 9 #1276

Closed

Merge remote-tracking branch 'upstream/master' into upgrade_validator

6e98f29

thinkerou mentioned this pull request May 20, 2018

Runtime Error BindJson #1361

Closed

thinkerou mentioned this pull request Sep 4, 2018

adding support for go-playground/validator.v9 #1527

Closed

thinkerou mentioned this pull request Oct 15, 2018

chore(deps): update module go-playground/validator to v9 renovate-mirrors/gin#6

Open

1 task

thinkerou self-assigned this Dec 12, 2018

thinkerou requested review from javierprovecho and appleboy May 22, 2019 15:39

appleboy previously approved these changes May 23, 2019

View reviewed changes

Merge branch 'master' into upgrade_validator

823bb20

xizhibei mentioned this pull request Jun 16, 2019

Golang validator 详解 xizhibei/blog#110

Open

thinkerou mentioned this pull request Jul 5, 2019

please upgrade gopkg.in/go-playground/validator.v8 #1976

Closed

Update go.mod

8a92325

thinkerou dismissed appleboy’s stale review via 8a92325 September 4, 2019 04:06

thinkerou added 4 commits September 4, 2019 12:06

Update go.sum

8f09d0e

Update go.mod

8c0d69e

Update go.sum

8b57e9c

Merge branch 'master' into upgrade_validator

7abcefa

appleboy approved these changes Sep 4, 2019

View reviewed changes

appleboy added the break-backward label Sep 4, 2019

Merge branch 'master' into upgrade_validator

5610fa4

thinkerou merged commit 1acb3fb into gin-gonic:master Sep 5, 2019

thinkerou mentioned this pull request Sep 27, 2019

can i use gopkg.in/go-playground/validator.v9? #2077

Closed

hrool mentioned this pull request Oct 17, 2019

need to update readme and examples because validator has upgraded to v9 #2099

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade validator version to v9 #1015

upgrade validator version to v9 #1015

thinkerou commented Jul 13, 2017

appleboy commented Jul 13, 2017

cch123 commented Jul 13, 2017 •

edited

Loading

codecov bot commented Jul 13, 2017 •

edited

Loading

javierprovecho commented Jul 13, 2017

javierprovecho commented Jul 16, 2017

ghost left a comment •

edited by ghost

Loading

ashtonian commented May 1, 2018

thinkerou commented May 20, 2018

zwhitchcox commented May 21, 2018

Ianwww commented Jul 10, 2018

kishaningithub commented Aug 27, 2018

tomriddle1234 commented Sep 4, 2018

FaithOliviaTKPD commented Sep 24, 2018 •

edited

Loading

thinkerou commented Sep 25, 2018

rssathe commented Dec 18, 2018

plo- commented Feb 6, 2019

always-waiting commented Feb 21, 2019

always-waiting commented Feb 21, 2019

thinkerou commented Feb 21, 2019

dmarkham commented May 22, 2019

thinkerou commented May 22, 2019 •

edited

Loading

thinkerou commented May 26, 2019

TonyPythoneer commented Jun 24, 2019

souravray commented Jul 19, 2019

Askadias commented Sep 4, 2019

appleboy commented Sep 4, 2019

thinkerou commented Sep 4, 2019

thinkerou commented Sep 5, 2019

appleboy commented Sep 5, 2019

thinkerou commented Sep 5, 2019

upgrade validator version to v9 #1015

upgrade validator version to v9 #1015

Conversation

thinkerou commented Jul 13, 2017

appleboy commented Jul 13, 2017

cch123 commented Jul 13, 2017 • edited Loading

codecov bot commented Jul 13, 2017 • edited Loading

Codecov Report

javierprovecho commented Jul 13, 2017

javierprovecho commented Jul 16, 2017

ghost left a comment • edited by ghost Loading

Choose a reason for hiding this comment

ashtonian commented May 1, 2018

thinkerou commented May 20, 2018

zwhitchcox commented May 21, 2018

Ianwww commented Jul 10, 2018

kishaningithub commented Aug 27, 2018

tomriddle1234 commented Sep 4, 2018

FaithOliviaTKPD commented Sep 24, 2018 • edited Loading

thinkerou commented Sep 25, 2018

rssathe commented Dec 18, 2018

plo- commented Feb 6, 2019

always-waiting commented Feb 21, 2019

always-waiting commented Feb 21, 2019

thinkerou commented Feb 21, 2019

dmarkham commented May 22, 2019

thinkerou commented May 22, 2019 • edited Loading

thinkerou commented May 26, 2019

TonyPythoneer commented Jun 24, 2019

souravray commented Jul 19, 2019

Askadias commented Sep 4, 2019

appleboy commented Sep 4, 2019

thinkerou commented Sep 4, 2019

thinkerou commented Sep 5, 2019

appleboy commented Sep 5, 2019

thinkerou commented Sep 5, 2019

cch123 commented Jul 13, 2017 •

edited

Loading

codecov bot commented Jul 13, 2017 •

edited

Loading

ghost left a comment •

edited by ghost

Loading

FaithOliviaTKPD commented Sep 24, 2018 •

edited

Loading

thinkerou commented May 22, 2019 •

edited

Loading