Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error description of release v1.4.0 #1908

Closed
scarbo87 opened this issue May 20, 2019 · 2 comments
Closed

error description of release v1.4.0 #1908

scarbo87 opened this issue May 20, 2019 · 2 comments

Comments

@scarbo87
Copy link

Guys, you wrote in description to release v1.4.0 that included PR NEW context: inherits context cancellation and deadline from http.Request context for Go>=1.7 #1690, but you reverted this code. Why?
@thinkerou
Copy link
Member

@scarbo87 sorry about gin v1.4.0 release description, that pull request reverted and please see #1736, thanks!
maybe we should release gin v1.4.1 to fix some issue. cc @appleboy

@appleboy
Copy link
Member

@scarbo87 I updated the release documentation in v1.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@appleboy @scarbo87 @thinkerou