-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-semver release tags don't work with vgo #1388
Comments
Hi @bcl gin have had ➜ basic git:(vgo) ✗ vgo list -t github.com/gohugoio/hugo
github.com/gohugoio/hugo
v0.18.1
v0.20.1
v0.20.2
v0.20.3
v0.20.4
v0.20.5
v0.20.6
v0.20.7
v0.22.1
v0.24.1
v0.25.1
v0.27.1
v0.30.1
v0.30.2
v0.31.1
v0.32.1
v0.32.2
v0.32.3
v0.32.4
v0.36.1
v0.37.1
v0.38.1
v0.38.2
v0.40.1
v0.40.2
v0.40.3 And |
Oh @bcl I see your comment golang/go#25656 (comment) |
There is some discussion here:
And here is the relevant part of the semver spec:
|
Thanks for the pointer, I had missed that discussion. It's pretty clear that projects are going to need to use semver tagging and that vgo isn't going to kludge around it (other than the v0.0.0 commit hash option). So it would be helpful if a v1.2.0 tag could be added, I don't see any reason why not, the next version is going to be v1.2.1 anyway, right? |
We need @javierprovecho to create a new tag. maybe |
change logs for v1.3.0 #1478 |
Hi, everybody v1.3.0 have released! https://github.com/gin-gonic/gin/releases/tag/v1.3.0 |
I'm experimenting with vgo, and it won't recognize the v1.2 release when I list available releases:
vgo list -t github.com/gin-gonic/gin
github.com/gin-gonic/gin
v1.1.1
v1.1.2
v1.1.3
v1.1.4
I'm pretty sure this is because it is expecting semver tags. Would it be possible for you to add a tag for v1.2.0?
The text was updated successfully, but these errors were encountered: