Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why use github.com/json-iterator/go #1008

Closed
robscc opened this issue Jul 12, 2017 · 10 comments · Fixed by #1011
Closed

why use github.com/json-iterator/go #1008

robscc opened this issue Jul 12, 2017 · 10 comments · Fixed by #1011
Labels

Comments

@robscc
Copy link

robscc commented Jul 12, 2017

i have occurred an error in using json-iterator
json-iterator/go#129

@tboerger
Copy link
Contributor

We have integrated it because it's faster than the stdlib

@taowen
Copy link

taowen commented Jul 12, 2017

sorry about the bug, I will fix it as soon as possible. Test coverage is our recent focus.

@taowen
Copy link

taowen commented Jul 12, 2017

should be fixed now, you need to use the latest master branch. The map key is read from the buffer without copy, which caused this bug.

@appleboy
Copy link
Member

fix from json-iterator/go@bd4364a Thanks @taowen

@javierprovecho
Copy link
Member

awesome, thanks @taowen 😄

@taowen
Copy link

taowen commented Jul 12, 2017

@javierprovecho @appleboy thanks for choosing jsoniter. There are bugs for sure, I can only promise to fix them as soon as I can.

@codedance
Copy link

jsoniter also does not seem to work on Google App Engine (use of unsafe). One option may be to enable/disable this via build tags.

@taowen
Copy link

taowen commented Jul 16, 2017

jsoniter is based on unsafe.Pointer which seems not allowed by GAE. build tags is an option.

@codedance
Copy link

Wow. Nice work with jumping on this so quick. I think refactoring to enable via a built-tag is the right idea. It allows evolution and innovation, while reducing the risk by giving it time to bake.

@appleboy
Copy link
Member

See #1026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants