Reworked readline code such that it checks that client is connected before attempting a read. Which solved the crash in issue #46

Author: gilmaimon

src/tiny_websockets/network/generic_esp/generic_esp_clients.hpp

@@ -48,15 +48,15 @@ namespace websockets { namespace network {
     }
 
     WSString readLine() override {
-      int val;
-      WSString line;
-      do {
-        yield();
-        val = client.read();
-        if(val < 0) continue;
-        line += (char)val;
-      } while(val != '\n');
-      if(!available()) close();
+      WSString line = "";
+
+      int ch = -1;
+      while( ch != '\n' && available()) {
+        ch = client.read();
+        if (ch < 0) continue;
+        line += (char) ch;
+      }
+
       return line;
     }
 

src/websockets_client.cpp

@@ -277,6 +277,12 @@ namespace websockets {
         WSString line = "";
         while (true) {
             line = this->_client->readLine();
+
+            if (line.size() < 2) {
+                close(CloseReason_ProtocolError);
+                return false;
+            }
+
             if (line == "\r\n") break;
             // remove /r/n from line end
             line = line.substr(0, line.size() - 2);