-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new response error for client's error encoder #40
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
70413d0
added ResponseError to spec
xh3b4sd 9aa2df1
added basic response error structure
xh3b4sd 628cbd4
use new response error in client's error encoder
xh3b4sd d2fa22c
make router injectable
xh3b4sd 30b7440
fixed error handling in error encoder
xh3b4sd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
package server | ||
|
||
import ( | ||
microerror "github.com/giantswarm/microkit/error" | ||
kithttp "github.com/go-kit/kit/transport/http" | ||
) | ||
|
||
// ResponseErrorConfig represents the configuration used to create a new | ||
// response error. | ||
type ResponseErrorConfig struct { | ||
// Settings. | ||
Underlying error | ||
} | ||
|
||
// DefaultResponseErrorConfig provides a default configuration to create a new | ||
// response error by best effort. | ||
func DefaultResponseErrorConfig() ResponseErrorConfig { | ||
return ResponseErrorConfig{ | ||
// Settings. | ||
Underlying: nil, | ||
} | ||
} | ||
|
||
// New creates a new configured response error. | ||
func NewResponseError(config ResponseErrorConfig) (ResponseError, error) { | ||
// Settings. | ||
if config.Underlying == nil { | ||
return nil, microerror.MaskAnyf(invalidConfigError, "underlying must not be empty") | ||
} | ||
|
||
newResponseError := &responseError{ | ||
// Internals. | ||
code: CodeUnknownError, | ||
message: errorMessage(config.Underlying), | ||
|
||
// Settings. | ||
underlying: config.Underlying, | ||
} | ||
|
||
return newResponseError, nil | ||
} | ||
|
||
type responseError struct { | ||
// Internals. | ||
code string | ||
message string | ||
|
||
// Settings. | ||
underlying error | ||
} | ||
|
||
func (e *responseError) Code() string { | ||
return e.code | ||
} | ||
|
||
func (e *responseError) Error() string { | ||
return e.underlying.Error() | ||
} | ||
|
||
func (e *responseError) Message() string { | ||
return e.message | ||
} | ||
|
||
func (e *responseError) IsEndpoint() bool { | ||
switch u := e.underlying.(type) { | ||
case kithttp.Error: | ||
switch u.Domain { | ||
case kithttp.DomainEncode: | ||
return true | ||
case kithttp.DomainDecode: | ||
return true | ||
case kithttp.DomainDo: | ||
return true | ||
} | ||
} | ||
|
||
return false | ||
} | ||
|
||
func (e *responseError) SetCode(code string) { | ||
e.code = code | ||
} | ||
|
||
func (e *responseError) SetMessage(message string) { | ||
e.message = message | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The router is now configurable which makes it easy to provide seamless migration paths towards microkit. This was rather easy to accomplish at the end. Back then I struggled conceptually.