use new response error for client's error encoder #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xh3b4sd
commented
Jan 19, 2017
| @@ -93,6 +93,7 @@ func (c *command) Execute(cmd *cobra.Command, args []string) { | |||
| serverConfig.ListenAddress = Flags.Server.Listen.Address | |||
| serverConfig.Logger = c.logger | |||
| serverConfig.RequestFuncs = customServer.RequestFuncs() | |||
| serverConfig.Router = customServer.Router() | |||
There was a problem hiding this comment.
The router is now configurable which makes it easy to provide seamless migration paths towards microkit. This was rather easy to accomplish at the end. Back then I struggled conceptually.
xh3b4sd
commented
Jan 19, 2017
|
|
||
| // Settings. | ||
| ListenAddress: "http://127.0.0.1:8080", | ||
| ListenAddress: "http://127.0.0.1:8000", |
There was a problem hiding this comment.
I only want to align this with the default port on G8S.
xh3b4sd
commented
Jan 19, 2017
| handler := s.NewRouter() | ||
| // Define our custom not found handler. Here we take care about logging, | ||
| // metrics and a proper response. | ||
| s.router.NotFoundHandler = http.Handler(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
Now the router initialization happens only once during boot, which makes perfect sense.
xh3b4sd
commented
Jan 19, 2017
| w.Header().Set("Content-Type", "application/json; charset=utf-8") | ||
| json.NewEncoder(w).Encode(map[string]interface{}{ | ||
| "error": errMessage, | ||
| "code": responseError.Code(), |
There was a problem hiding this comment.
I want to enable microservices to provide a proper response including machine readable codes. This standard applies then across all of our services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.