Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ghiscoding/slickgrid-universal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.5.1
Choose a base ref
...
head repository: ghiscoding/slickgrid-universal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.5.2
Choose a head ref
  • 7 commits
  • 73 files changed
  • 2 contributors

Commits on Aug 17, 2024

  1. fix: use setTimeout/setInterval from window object with correct TS type 

    - newest version of `@types/node` and TypeScript is sometime throwing some errors, especially in Angular "TS2503: Cannot find namespace 'NodeJS [plugin angular-compiler]'"
- I thought that we should always use `setTimeout` directly but its type is `NodeJS.timeout` type, however we should be using `window.setTimeout` with a return type of `number` instead since our project is always a Browser App hence the use of the `window` object
    @ghiscoding
    ghiscoding committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    63953ec View commit details
    Browse the repository at this point in the history

  2. chore: also use window object for clearSetTimeout

    @ghiscoding
    ghiscoding committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    422e861 View commit details
    Browse the repository at this point in the history

  3. chore: fix failing E2E tests by adding back deleted condition

    @ghiscoding
    ghiscoding committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    afe757d View commit details
    Browse the repository at this point in the history

  4. chore: remove unnecessary type casting

    @ghiscoding
    ghiscoding committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    257e7e1 View commit details
    Browse the repository at this point in the history

  5. chore: timers can be optionals

    @ghiscoding
    ghiscoding committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    7fc57ce View commit details
    Browse the repository at this point in the history

  6. Merge pull request #1643 from ghiscoding/bugfix/settimeout-types 

    fix: use setTimeout/setInterval from window object with correct TS type
    @ghiscoding
    ghiscoding authored Aug 17, 2024
    Configuration menu
    Copy the full SHA
    14c04d7 View commit details
    Browse the repository at this point in the history

  7. chore(release): publish new version v5.5.2

    @ghiscoding
    ghiscoding committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    f904ee3 View commit details
    Browse the repository at this point in the history
Loading