Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ghiscoding/Angular-Slickgrid
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.11.1
Choose a base ref
...
head repository: ghiscoding/Angular-Slickgrid
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.11.2
Choose a head ref
  • 6 commits
  • 18 files changed
  • 2 contributors

Commits on Oct 4, 2019

  1. feat(example): add programmatically Pagination change sample

    @ghiscoding-SE
    ghiscoding-SE committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    a150807 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2019

  1. fix(gridService): upsertItem(s) should trigger onItemAdded/Updated event

    @ghiscoding-SE
    ghiscoding-SE committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    df9af21 View commit details
    Browse the repository at this point in the history

  2. fix(pagination): when item is added it should trigger pagination changed

    @ghiscoding-SE
    ghiscoding-SE committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    c953a23 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2019

  1. fix(paging): don't reset page 1 after manually adding items to grid 

    - manually adding items (via the grid service addItem()) shouldn't reset pagination to page 1
- completely change how we pass the options to the child pagination component
- no longer relying on the entire grid option to be passed to the pagination (which was error pron)
- now passes only the essential options required by the pagination
    @ghiscoding-SE
    ghiscoding-SE committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    f61285d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #302 from ghiscoding/bugfix/graphql-pagination-reload 

    fix(pagination): when item is added it should trigger pagination changed
    @ghiscoding
    ghiscoding authored Oct 7, 2019
    Configuration menu
    Copy the full SHA
    d0795bb View commit details
    Browse the repository at this point in the history

  3. chore(release): 2.11.2

    @ghiscoding-SE
    ghiscoding-SE committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    2c73c65 View commit details
    Browse the repository at this point in the history
Loading