Skip to content

Commit c439324

Browse files
committed
fix(observables): http cancellable Subject should be unsubscribed
1 parent a84b489 commit c439324

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

src/app/modules/angular-slickgrid/services/filter.service.ts

+1
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ export class FilterService {
100100
}
101101
if (isObservable(this.httpCancelRequests$)) {
102102
this.httpCancelRequests$.next(); // this cancels any pending http requests
103+
this.httpCancelRequests$.unsubscribe();
103104
}
104105
this.disposeColumnFilters();
105106
this._onSearchChange = null;

src/app/modules/angular-slickgrid/services/sort.service.ts

+1
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ export class SortService {
187187
}
188188
if (isObservable(this.httpCancelRequests$)) {
189189
this.httpCancelRequests$.next(); // this cancels any pending http requests
190+
this.httpCancelRequests$.unsubscribe();
190191
}
191192
}
192193

0 commit comments

Comments
 (0)