fix(menu): remove unused code in Context Menu to select cell

- the call to the `setActiveCell()` is actually not working there, it should be called after the menu is shown, not after doing the action which is too late

Author: ghiscoding-SE

src/app/modules/angular-slickgrid/extensions/__tests__/contextMenuExtension.spec.ts

@@ -9,10 +9,7 @@ import { Column, DelimiterType, FileType, GridOption, MenuCommandItem, MenuComma
 import { Formatters } from '../../formatters';
 
 declare var Slick: any;
-
-const gridId = 'grid1';
 const gridUid = 'slickgrid_124343';
-const containerId = 'demo-container';
 
 const excelExportServiceStub = {
   exportToExcel: jest.fn(),
@@ -546,7 +543,6 @@ describe('contextMenuExtension', () => {
       });
 
       it('should call "copyToClipboard", without export formatter, when the command triggered is "copy"', () => {
-        const setActiveCellSpy = jest.spyOn(SharedService.prototype.grid, 'setActiveCell');
         const copyGridOptionsMock = { ...gridOptionsMock, enableExcelExport: false, enableExport: false, contextMenu: { hideCopyCellValueCommand: false } } as GridOption;
         const columnMock = { id: 'firstName', name: 'First Name', field: 'firstName' } as Column;
         const dataContextMock = { id: 123, firstName: 'John', lastName: 'Doe', age: 50 };
@@ -567,12 +563,10 @@ describe('contextMenuExtension', () => {
           value: 'John'
         });
 
-        expect(setActiveCellSpy).toHaveBeenCalledWith(5, 2, false);
         expect(execSpy).toHaveBeenCalledWith('copy', false, 'John');
       });
 
       it('should call "copyToClipboard", WITH export formatter, when the command triggered is "copy"', () => {
-        const setActiveCellSpy = jest.spyOn(SharedService.prototype.grid, 'setActiveCell');
         const copyGridOptionsMock = { ...gridOptionsMock, enableExcelExport: false, enableExport: false, exportOptions: { exportWithFormatter: true } } as GridOption;
         const columnMock = { id: 'firstName', name: 'First Name', field: 'firstName', formatter: Formatters.uppercase } as Column;
         const dataContextMock = { id: 123, firstName: 'John', lastName: 'Doe', age: 50 };
@@ -592,7 +586,6 @@ describe('contextMenuExtension', () => {
           value: 'John'
         });
 
-        expect(setActiveCellSpy).toHaveBeenCalledWith(5, 2, false);
         expect(execSpy).toHaveBeenCalledWith('copy', false, 'JOHN');
       });
 

src/app/modules/angular-slickgrid/extensions/contextMenuExtension.ts

@@ -181,10 +181,7 @@ export class ContextMenuExtension implements Extension {
             command: commandName,
             positionOrder: 50,
             action: (e: Event, args: MenuCommandItemCallbackArgs) => {
-              if (args && args.hasOwnProperty('cell') && args.hasOwnProperty('row')) {
-                this.sharedService.grid.setActiveCell(args.row, args.cell, false); // select the cell that the click originated
-                this.copyToClipboard(args);
-              }
+              this.copyToClipboard(args);
             },
             itemUsabilityOverride: (args: MenuCallbackArgs) => {
               // make sure there's an item to copy before enabling this command