fix(extension): registerPlugin not implemented correctly (#482)

Author: ghiscoding

src/app/modules/angular-slickgrid/services/__tests__/extension.service.spec.ts

@@ -30,6 +30,7 @@ const gridStub = {
   getColumnIndex: jest.fn(),
   getScrollbarDimensions: jest.fn(),
   getOptions: jest.fn(),
+  getPluginByName: jest.fn(),
   getColumns: jest.fn(),
   setColumns: jest.fn(),
   onColumnsReordered: jest.fn(),
@@ -413,7 +414,8 @@ describe('ExtensionService', () => {
         const gridOptionsMock = { registerPlugins: [pluginMock] } as GridOption;
         const gridSpy = jest.spyOn(SharedService.prototype, 'grid', 'get').mockReturnValue(gridStub);
         const optionSpy = jest.spyOn(SharedService.prototype, 'gridOptions', 'get').mockReturnValue(gridOptionsMock);
-        const pluginSpy = jest.spyOn(SharedService.prototype.grid, 'registerPlugin').mockReturnValue(instanceMock);
+        const pluginSpy = jest.spyOn(SharedService.prototype.grid, 'registerPlugin');
+        jest.spyOn(SharedService.prototype.grid, 'getPluginByName').mockReturnValue(instanceMock);
 
         service.bindDifferentExtensions();
         const output = service.getExtensionByName(ExtensionName.noname);
@@ -430,7 +432,8 @@ describe('ExtensionService', () => {
         const gridOptionsMock = { registerPlugins: pluginMock } as GridOption;
         const gridSpy = jest.spyOn(SharedService.prototype, 'grid', 'get').mockReturnValue(gridStub);
         const optionSpy = jest.spyOn(SharedService.prototype, 'gridOptions', 'get').mockReturnValue(gridOptionsMock);
-        const pluginSpy = jest.spyOn(SharedService.prototype.grid, 'registerPlugin').mockReturnValue(instanceMock);
+        const pluginSpy = jest.spyOn(SharedService.prototype.grid, 'registerPlugin');
+        jest.spyOn(SharedService.prototype.grid, 'getPluginByName').mockReturnValue(instanceMock);
 
         service.bindDifferentExtensions();
         const output = service.getExtensionByName(ExtensionName.noname);

src/app/modules/angular-slickgrid/services/extension.service.ts

@@ -245,15 +245,19 @@ export class ExtensionService {
 
       // manually register other plugins
       if (this.sharedService.gridOptions.registerPlugins !== undefined) {
-        if (Array.isArray(this.sharedService.gridOptions.registerPlugins)) {
-          this.sharedService.gridOptions.registerPlugins.forEach((plugin) => {
-            const instance = this.sharedService.grid.registerPlugin(plugin);
+        const grid = this.sharedService.grid;
+        const gridOptions = this.sharedService.gridOptions;
+
+        if (Array.isArray(gridOptions.registerPlugins)) {
+          gridOptions.registerPlugins.forEach((plugin: any) => {
+            grid.registerPlugin(plugin);
+            const instance = grid.getPluginByName(plugin && plugin.name || '');
             this._extensionList.push({ name: ExtensionName.noname, class: null, addon: instance, instance });
           });
         } else {
-          this.sharedService.grid.registerPlugin(this.sharedService.gridOptions.registerPlugins);
-          const plugin = this.sharedService.gridOptions.registerPlugins;
-          const instance = this.sharedService.grid.registerPlugin(plugin);
+          const plugin = gridOptions.registerPlugins;
+          grid.registerPlugin(plugin);
+          const instance = grid.getPluginByName(plugin && plugin.name || '');
           this._extensionList.push({ name: ExtensionName.noname, class: null, addon: instance, instance });
         }
       }