Skip to content

Commit 8f16559

Browse files
fix(rowDetail): use latest SlickGrid to fix issue with id, fixes #440 (#449)
- there was a small issue in core lib when using "datasetIdPropertyName" other than "id" so update to latest SlickGrid version which has the fix - change default grid options of Row Detail "useRowClick" property to false Co-authored-by: Ghislain Beaulac <ghislain.beaulac@se.com>
1 parent b10c5be commit 8f16559

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@
9090
"lodash.isequal": "^4.5.0",
9191
"moment-mini": "^2.22.1",
9292
"rxjs": "^6.3.3",
93-
"slickgrid": "2.4.20",
93+
"slickgrid": "^2.4.22",
9494
"text-encoding-utf-8": "^1.0.2"
9595
},
9696
"devDependencies": {

src/app/modules/angular-slickgrid/global-grid-options.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -160,13 +160,13 @@ export const GlobalGridOptions: Partial<GridOption> = {
160160
pageSize: 25,
161161
totalItems: 0
162162
},
163-
// @ts-ignore
164163
// technically speaking the Row Detail requires the process & viewComponent but we'll ignore it just to set certain options
164+
// @ts-ignore
165165
rowDetailView: {
166166
cssClass: 'detail-view-toggle',
167167
panelRows: 1,
168168
keyPrefix: '__',
169-
useRowClick: true,
169+
useRowClick: false,
170170
useSimpleViewportCalc: true,
171171
saveDetailViewOnScroll: false,
172172
},

0 commit comments

Comments
 (0)