Skip to content

Commit 72fb260

Browse files
committed
fix: regression externalResouces should work globally, fix #1329
- fixes issue #1329 - external resources can also be loaded globally in the forRoot and that regressed in previous PR #1320
1 parent 0654550 commit 72fb260

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/app/modules/angular-slickgrid/components/angular-slickgrid.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ export class AngularSlickgridComponent<TData = any> implements AfterViewInit, On
348348

349349
// save resource refs to register before the grid options are merged and possibly deep copied
350350
// since a deep copy of grid options would lose original resource refs but we want to keep them as singleton
351-
this._registeredResources = this.gridOptions?.externalResources || [];
351+
this._registeredResources = ({ ...this.forRootConfig, ...this.gridOptions } as GridOption)?.externalResources || [];
352352

353353
this.initialization(this._eventHandler);
354354
this._isGridInitialized = true;

0 commit comments

Comments
 (0)