Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

fix(pinning): recalculate frozen idx correctly when column shown changes #682

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

ghiscoding
Copy link
Owner

  • when using ColumnPicker, GridMenu or hiding a column via HeaderMenu, it has to recalculate the frozenColumn index because SlickGrid doesn't take care of that and the previous fix that I implement sometimes become out of sync. This PR simplifies the frozenColumn index position, it will simply update it when the index is different, as simple as that.

- when using ColumnPicker, GridMenu or hiding a column via HeaderMenu, it has to recalculate the frozenColumn index because SlickGrid doesn't take care of that and the previous fix that I implement sometimes become out of sync. This PR simplifies the frozenColumn index position, it will simply update it when the index is different, as simple as that.
@ghiscoding ghiscoding changed the title fix(pinning): recalculate frozen idx properly when column shown changes fix(pinning): recalculate frozen idx correctly when column shown changes Jan 22, 2021
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #682 (c6b7bd1) into master (7b95401) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #682    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          157       157            
  Lines        10458     10451     -7     
  Branches      3515      3665   +150     
==========================================
- Hits         10458     10451     -7     
Impacted Files Coverage Δ
...ular-slickgrid/extensions/columnPickerExtension.ts 100.00% <100.00%> (ø)
...s/angular-slickgrid/extensions/extensionUtility.ts 100.00% <100.00%> (ø)
.../angular-slickgrid/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...ngular-slickgrid/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b95401...c6b7bd1. Read the comment docs.

@ghiscoding ghiscoding merged commit 996125d into master Jan 25, 2021
@ghiscoding ghiscoding deleted the bugfix/frozen-picker-column-change branch January 25, 2021 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant