fix(lint): adhere to strict triple equality check (#477)

Author: ghiscoding-SE

src/app/examples/custom-angularComponentEditor.ts

@@ -161,7 +161,7 @@ export class CustomAngularComponentEditor implements Editor {
   }
 
   isValueChanged() {
-    return (!(this.componentRef.instance.selectedId === '' && this.defaultId == null)) && (this.componentRef.instance.selectedId !== this.defaultId);
+    return (!(this.componentRef.instance.selectedId === '' && (this.defaultId === null || this.defaultId === undefined))) && (this.componentRef.instance.selectedId !== this.defaultId);
   }
 
   validate(): EditorValidatorOutput {

src/app/examples/grid-editor.component.ts

@@ -41,7 +41,7 @@ const myCustomTitleValidator: EditorValidator = (value: any, args: EditorArgs) =
   // don't use "editor" property since that one is what SlickGrid uses internally by it's editor factory
   const columnEditor = args && args.column && args.column.internalColumnEditor;
 
-  if (value == null || value === undefined || !value.length) {
+  if (value === null || value === undefined || !value.length) {
     return { valid: false, msg: 'This is a required field' };
   } else if (!/^Task\s\d+$/.test(value)) {
     return { valid: false, msg: 'Your title is invalid, it must start with "Task" followed by a number' };
@@ -644,6 +644,7 @@ export class GridEditorComponent implements OnInit {
 
   undo() {
     const command = this._commandQueue.pop();
+    const item = this.angularGrid.dataView.getItem(command.row);
     if (command && Slick.GlobalEditorLock.cancelCurrentEdit()) {
       command.undo();
       this.gridObj.gotoCell(command.row, command.cell, false);

src/app/modules/angular-slickgrid/aggregators/avgAggregator.ts

@@ -19,7 +19,7 @@ export class AvgAggregator implements Aggregator {
   accumulate(item: any) {
     const val = (item && item.hasOwnProperty(this._field)) ? item[this._field] : null;
     this._count++;
-    if (val != null && val !== '' && !isNaN(val)) {
+    if (val !== null && val !== undefined && val !== '' && !isNaN(val)) {
       this._nonNullCount++;
       this._sum += parseFloat(val);
     }

src/app/modules/angular-slickgrid/aggregators/maxAggregator.ts

@@ -14,8 +14,8 @@ export class MaxAggregator implements Aggregator {
 
   accumulate(item: any) {
     const val = (item && item.hasOwnProperty(this._field)) ? item[this._field] : null;
-    if (val != null && val !== '' && !isNaN(val)) {
-      if (this._max == null || val > this._max) {
+    if (val !== null && val !== undefined && val !== '' && !isNaN(val)) {
+      if (this._max === null || this._max === undefined || val > this._max) {
         this._max = parseFloat(val);
       }
     }

src/app/modules/angular-slickgrid/aggregators/minAggregator.ts

@@ -14,8 +14,8 @@ export class MinAggregator implements Aggregator {
 
   accumulate(item: any) {
     const val = (item && item.hasOwnProperty(this._field)) ? item[this._field] : null;
-    if (val != null && val !== '' && !isNaN(val)) {
-      if (this._min == null || val < this._min) {
+    if (val !== null && val !== undefined && val !== '' && !isNaN(val)) {
+      if (this._min === null || this._min === undefined || val < this._min) {
         this._min = parseFloat(val);
       }
     }

src/app/modules/angular-slickgrid/aggregators/sumAggregator.ts

@@ -14,7 +14,7 @@ export class SumAggregator implements Aggregator {
 
   accumulate(item: any) {
     const val = (item && item.hasOwnProperty(this._field)) ? item[this._field] : null;
-    if (val != null && val !== '' && !isNaN(val)) {
+    if (val !== null && val !== undefined && val !== '' && !isNaN(val)) {
       this._sum += parseFloat(val);
     }
   }

src/app/modules/angular-slickgrid/grouping-formatters/avgTotalsDollarFormatter.ts

@@ -14,7 +14,7 @@ export const avgTotalsDollarFormatter: GroupTotalsFormatter = (totals: any, colu
   const thousandSeparator = getValueFromParamsOrFormatterOptions('thousandSeparator', columnDef, grid, '');
   const displayNegativeNumberWithParentheses = getValueFromParamsOrFormatterOptions('displayNegativeNumberWithParentheses', columnDef, grid, false);
 
-  if (val != null && !isNaN(+val)) {
+  if (val !== null && val !== undefined && !isNaN(+val)) {
     const formattedNumber = formatNumber(val, minDecimal, maxDecimal, displayNegativeNumberWithParentheses, '$', '', decimalSeparator, thousandSeparator);
     return `${prefix}${formattedNumber}${suffix}`;
   }

src/app/modules/angular-slickgrid/grouping-formatters/avgTotalsFormatter.ts

@@ -14,7 +14,7 @@ export const avgTotalsFormatter: GroupTotalsFormatter = (totals: any, columnDef:
   const thousandSeparator = getValueFromParamsOrFormatterOptions('thousandSeparator', columnDef, grid, '');
   const displayNegativeNumberWithParentheses = getValueFromParamsOrFormatterOptions('displayNegativeNumberWithParentheses', columnDef, grid, false);
 
-  if (val != null && !isNaN(+val)) {
+  if (val !== null && val !== undefined && !isNaN(+val)) {
     if (val < 0) {
       val = Math.abs(val);
       if (!displayNegativeNumberWithParentheses) {

src/app/modules/angular-slickgrid/grouping-formatters/avgTotalsPercentageFormatter.ts

@@ -14,7 +14,7 @@ export const avgTotalsPercentageFormatter: GroupTotalsFormatter = (totals: any,
   const thousandSeparator = getValueFromParamsOrFormatterOptions('thousandSeparator', columnDef, grid, '');
   const displayNegativeNumberWithParentheses = getValueFromParamsOrFormatterOptions('displayNegativeNumberWithParentheses', columnDef, grid, false);
 
-  if (val != null && !isNaN(+val)) {
+  if (val !== null && val !== undefined && !isNaN(+val)) {
     if (val < 0) {
       val = Math.abs(val);
       if (!displayNegativeNumberWithParentheses) {

src/app/modules/angular-slickgrid/grouping-formatters/maxTotalsFormatter.ts

@@ -14,7 +14,7 @@ export const maxTotalsFormatter: GroupTotalsFormatter = (totals: any, columnDef:
   const thousandSeparator = getValueFromParamsOrFormatterOptions('thousandSeparator', columnDef, grid, '');
   const displayNegativeNumberWithParentheses = getValueFromParamsOrFormatterOptions('displayNegativeNumberWithParentheses', columnDef, grid, false);
 
-  if (val != null && !isNaN(+val)) {
+  if (val !== null && val !== undefined && !isNaN(+val)) {
     const formattedNumber = formatNumber(val, minDecimal, maxDecimal, displayNegativeNumberWithParentheses, '', '', decimalSeparator, thousandSeparator);
     return `${prefix}${formattedNumber}${suffix}`;
   }