lora : raise error if lm_head is ignored #9103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltoniazzi
reviewed
Aug 20, 2024
| @@ -363,7 +363,11 @@ def get_tensors(self) -> Iterator[tuple[str, Tensor]]: | |||
| yield (name, cast(torch.Tensor, LoraTorchTensor(tensor.A, tensor.B))) | |||
|
|
|||
| def modify_tensors(self, data_torch: Tensor, name: str, bid: int | None) -> Iterable[tuple[str, Tensor]]: | |||
| dest = super().modify_tensors(data_torch, name, bid) | |||
| dest = list(super().modify_tensors(data_torch, name, bid)) | |||
There was a problem hiding this comment.
Is it needed to recast to a list super().modify_tensors(data_torch, name, bid)?
There was a problem hiding this comment.
Without this, pyright will not pass: https://github.com/ggerganov/llama.cpp/actions/runs/10472198558/job/29001100132
There was a problem hiding this comment.
Yes, this is needed because it can also be a Generator (when modify_tensors uses yield).
convert_lora_to_gguf.py
Outdated
| @@ -363,7 +363,11 @@ def get_tensors(self) -> Iterator[tuple[str, Tensor]]: | |||
| yield (name, cast(torch.Tensor, LoraTorchTensor(tensor.A, tensor.B))) | |||
|
|
|||
| def modify_tensors(self, data_torch: Tensor, name: str, bid: int | None) -> Iterable[tuple[str, Tensor]]: | |||
| dest = super().modify_tensors(data_torch, name, bid) | |||
| dest = list(super().modify_tensors(data_torch, name, bid)) | |||
| # for now, we cannot convert archs that use the same tensor for tok_embd and output | |||
There was a problem hiding this comment.
Suggested change
| # for now, we cannot convert archs that use the same tensor for tok_embd and output | |
| # for now, we cannot convert adapters with lm_head for archs that use the same tensor for tok_embd and output |
There was a problem hiding this comment.
I’ll rephrase this to void mixing naming scheme
compilade
approved these changes
Aug 21, 2024
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
* lora : raise error if lm_head is ignored * fix style * clarify comment
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
* lora : raise error if lm_head is ignored * fix style * clarify comment
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
* lora : raise error if lm_head is ignored * fix style * clarify comment
4 tasks
Nexesenex
pushed a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Feb 25, 2025
* lora : raise error if lm_head is ignored * fix style * clarify comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #9065
We will now raise an error if
lm_headis ignored in base model.TODO: @ltoniazzi can you test this? Thanks.