server: explicitly set exec path when create new instance #17669
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f2dbe9c.
ngxson
force-pushed
the
xsn/server_explicit_exec_path
branch
from
58cfded to
895aabb
Compare
ggerganov
reviewed
Dec 2, 2025
tools/server/server-models.cpp
Outdated
| int argc, | ||
| char ** argv, | ||
| char ** envp) : base_params(params) { | ||
| char ** envp) : base_params(params), server_binary_path(get_server_exec_path().string()) { |
Member
There was a problem hiding this comment.
When get_server_exec_path throws, should we instead fallback to using argv[0] as the server binary path?
Collaborator
Author
There was a problem hiding this comment.
yes that's a good idea, I added it in 0dbf1e7
ggerganov
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #16487 (comment)
In some cases, the first argument from the parent process doesn't reflect the binary path. So, we always resolve the binary path manually to make sure that it works.