Skip to content

Conversation

@ngxson
Copy link
Collaborator

@ngxson ngxson commented Dec 1, 2025

Fix #17666

Important

This PR changes the way how model name is handle (see below).
In addition to that, the "model" field from input request no longer be reflected back to the response. If you need to use a custom model name, set it via --model-alias argument instead

Remove the default gpt-3.5-turbo model name as was useful in the past, but no longer be the case.

The model name is now decided based on this priority:

  • If model_alias is set, use it
  • Otherwise, use registry format <user>/<model>:<tag> if available (for cached models)
  • Fallback to file name if none is found

After the change, web UI display the model name correctly:

llama-server -m ../models/DeepSeek-R1-Distill-Llama-8B-Q4_K_M.gguf
image

@ngxson ngxson requested a review from pwilkin December 1, 2025 22:02
@ngxson ngxson requested a review from ggerganov as a code owner December 1, 2025 22:02
Copy link
Collaborator

@pwilkin pwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be a generally safer approach anyway.

@pwilkin
Copy link
Collaborator

pwilkin commented Dec 1, 2025

You might want to also check the stats under the assistant response, I think that's where it bugged out for me (if you have 'show statistics' and 'show model name' checked in settings).

@ngxson
Copy link
Collaborator Author

ngxson commented Dec 1, 2025

Hmm yeah, it reflects back the input model name from the request. I think it's also time to remove this behavior as it doesn't make much sense.

@ngxson
Copy link
Collaborator Author

ngxson commented Dec 1, 2025

@pwilkin could you confirm if the latest commit resolves the problem on your side? (maybe there are cases that I haven't tested)

@pwilkin
Copy link
Collaborator

pwilkin commented Dec 1, 2025

Okay, pulling and will check.

@pwilkin
Copy link
Collaborator

pwilkin commented Dec 1, 2025

@ngxson can confirm, works good now.
image

@github-actions github-actions bot added examples python python script changes server labels Dec 1, 2025
@ngxson
Copy link
Collaborator Author

ngxson commented Dec 2, 2025

Merging this once most workflows passed on the mirrored PR: ngxson#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples python python script changes server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc. bug: Incorrect model name in web chat

2 participants