Skip to content

ggml: use 'exists( const std::filesystem::path&, std::error_code&)' instead of 'exists( const std::filesystem::path&)' to enhance robustness #17653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+15 −4
Open

ggml: use 'exists( const std::filesystem::path&, std::error_code&)' instead of 'exists( const std::filesystem::path&)' to enhance robustness #17653

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5eee97
Improve error handling for search path existence checks
flyinskyin2013 Dec 1, 2025
6cf2fdd
Improve cache file existence check with error code
flyinskyin2013 Dec 1, 2025
b4a02d2
Simplify existence check for search paths
flyinskyin2013 Dec 2, 2025
d5a7cb8
Fix logging path in error message for posix_stat
flyinskyin2013 Dec 2, 2025
6c4e8bc
Update ggml/src/ggml-backend-reg.cpp
flyinskyin2013 Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ggml/src/ggml-backend-reg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,10 +534,19 @@ static ggml_backend_reg_t ggml_backend_load_best(const char * name, bool silent,
fs::path best_path;

for (const auto & search_path : search_paths) {
if (!fs::exists(search_path)) {
GGML_LOG_DEBUG("%s: search path %s does not exist\n", __func__, path_str(search_path).c_str());
std::error_code ec;
bool is_exist = fs::exists(search_path, ec);
if (ec){
GGML_LOG_DEBUG("%s: posix_stat(%s) failure, error-message: %s\n", __func__, path_str(search_path).c_str(), ec.message().c_str());
continue;
}
else{
if (!is_exist) {
GGML_LOG_DEBUG("%s: search path %s does not exist\n", __func__, path_str(search_path).c_str());
continue;
}
}

fs::directory_iterator dir_it(search_path, fs::directory_options::skip_permission_denied);
for (const auto & entry : dir_it) {
if (entry.is_regular_file()) {
Expand Down Expand Up @@ -575,7 +584,8 @@ static ggml_backend_reg_t ggml_backend_load_best(const char * name, bool silent,
for (const auto & search_path : search_paths) {
fs::path filename = backend_filename_prefix().native() + name_path.native() + backend_filename_extension().native();
fs::path path = search_path / filename;
if (fs::exists(path)) {
std::error_code ec;
Copy link
Collaborator

@am17an am17an Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw all these can be a part of the if-init statement, not just the one I suggested

if (fs::exists(path, ec)) {
return get_reg().load_backend(path, silent);
}
}
Expand Down