ggml: use 'exists( const std::filesystem::path&, std::error_code&)' instead of 'exists( const std::filesystem::path&)' to enhance robustness #17653
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor existence checks for search paths using std::error_code to handle potential errors.
Update fs::exists to use std::error_code for error handling.
danbev
reviewed
Dec 1, 2025
ggml/src/ggml-backend-reg.cpp
Outdated
| if (!fs::exists(search_path)) { | ||
| GGML_LOG_DEBUG("%s: search path %s does not exist\n", __func__, path_str(search_path).c_str()); | ||
| std::error_code ec; | ||
| bool is_exist = fs::exists(search_path, ec); |
Member
There was a problem hiding this comment.
Perhaps this could be written as:
std::error_code ec;
if (!fs::exists(search_path, ec)) {
if (ec){
GGML_LOG_DEBUG("%s: posix_stat(%s) failure, error-message: %s\n", __func__, path_str(search_path).c_str(), ec.message().c_str());
} else{
GGML_LOG_DEBUG("%s: search path %s does not exist\n", __func__, path_str(search_path).c_str());
}
continue;
}
Contributor
Author
There was a problem hiding this comment.
OK, Simplify it now.
| fs::path path = search_path / filename; | ||
| if (fs::exists(path)) { | ||
| std::error_code ec; | ||
| if (fs::exists(path, ec)) { |
Member
There was a problem hiding this comment.
This should probably log the exception if it happens so that it does not just silently fail now.
Alternatively we could create a list of valid paths that we get from the previous iteration where they are already checked and then just use the exists function that throws an exception here.
Contributor
Author
There was a problem hiding this comment.
Improve-log is effective and simple, now, it's ready.
github-actions
bot
added
the
ggml
Simplify existence check for search paths
am17an
reviewed
Dec 2, 2025
Comment on lines
+537
to
+538
| std::error_code ec; | ||
| if (!fs::exists(search_path, ec)) { |
Collaborator
There was a problem hiding this comment.
Can be further simplified using if-init
Suggested change
| std::error_code ec; | |
| if (!fs::exists(search_path, ec)) { | |
| if (std::error_code ec; !fs::exists(search_path, ec)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use
exists( const std::filesystem::path& p), ifpcan't access(like: Permission denied), it will throwstd::filesystem::filesystem_errorto break the execution flow.