ggml: added missing cast sections in memcpy #17651
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwilkin
added
the
vibe-coded
github-actions
bot
added
the
ggml
danbev
reviewed
Dec 1, 2025
| @@ -6542,7 +6382,7 @@ static void ggml_compute_backward( | |||
| memcpy(&attn_factor, (const float *) tensor->op_params + 8, sizeof(float)); | |||
| memcpy(&beta_fast, (const float *) tensor->op_params + 9, sizeof(float)); | |||
| memcpy(&beta_slow, (const float *) tensor->op_params + 10, sizeof(float)); | |||
| memcpy(§ions, tensor->op_params + 11, sizeof(sections)); | |||
| memcpy(§ions, (const int *) tensor->op_params + 11, sizeof(sections)); | |||
Member
There was a problem hiding this comment.
I don't think this is strictly required and I think this is intentional as the type of op_params is:
int32_t op_params[GGML_MAX_OP_PARAMS / sizeof(int32_t)];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isn't it correct to bring the blocks to the sections type, which is int, as above for float?