GGML: Check for null buffers in get/set/copy tensor RPC endpoints #14868
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPC operations
RPC_CMD_SET_TENSOR
,RPC_CMD_SET_TENSOR_HASH
,RPC_CMD_GET_TENSOR
, andRPC_CMD_COPY_TENSOR
all require a backend buffer was previously allocated and located during the operation otherwise the code will subsequently crash with various NULL pointer dereferences. This adds checks for NULL pointer buffers afterdeserialize_tensor
is called for each operation.Tested the RPC changes loading various models over the RPC interface:
llama-cli on the client side:
and llama-bench