Skip to content

ggml: fix GGML_UNARY_OP_NAME order to align with enum ggml_unary_op #13717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lhez
Copy link
Contributor

@lhez lhez commented May 23, 2025

The names order in GGML_UNARY_OP_NAME mismatches that in enum ggml_unary_op. This causes problem when unit testing a specific unary op by passing the unary op name to test-backend-ops.

@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label May 23, 2025
@lhez lhez marked this pull request as ready for review May 23, 2025 05:30
@ngxson
Copy link
Collaborator

ngxson commented May 23, 2025

That was a mistake from #13667 , we should change the enum instead, I do that in the other PR

@ngxson ngxson closed this May 23, 2025
@lhez lhez deleted the fix-unary-op-name-order branch May 23, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants