Skip to content

Fix qwen3 template parsing, implement jinja slice step syntax #13181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

matteoserva
Copy link
Contributor

This implements the steps needed to parse messages[::-1] in Qwen3 template.
Fixes #13178

Sending same patch to upstream

@CISC
Copy link
Collaborator

CISC commented Apr 29, 2025

Sorry, but this does not implement the step parameter, look more closely at the code (and more specifically at SubscriptExpr).

Also, the template will still fail due to the startswith method.

@matteoserva
Copy link
Contributor Author

ok. basically useless. closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eval bug: Qwen3, failed to parse chat template (jinja)
2 participants