clip : remove boi/eoi embeddings for GLM-edge model (⚠️ breaking change) #13081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLM-edge model adds
<|begin_of_image|>
and<|end_of_image|>
as part of the image embedding, this was a hack because at the time of #10573 , special tokens are not supported byllama-llava-cli
This removes the mentioned hack, making the support of special tokens become more standard
Important
BREAKING CHANGE: If you are still using
libllava
, you will need to add these tokens in your chat template.If you are using
libmtmd
, no actions are required.Test result: