Don't crash on ftype (formerly f16) == 4 #917
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #709 I did not add an enum value 4 for
ftype
(formerlyf16
), and made the functionllama_ftype_name
strict in that aLLAMA_ASSERT
was raised. This made llama.cpp crash with such GPTQ model files.Add
LLAMA_FTYPE_MOSTLY_Q4_1_SOME_F16 = 4
and relaxllama_ftype_name
so that it returns a helpful string, which will also help future experiments with file types.Should fix #903