-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore : Fix vulkan related compiler warnings, add help text, improve CLI options #8477
Merged
0cc4m
merged 8 commits into
ggerganov:master
from
teleprint-me:fix-vulkan-shader-warnings
Jul 28, 2024
Merged
chore : Fix vulkan related compiler warnings, add help text, improve CLI options #8477
0cc4m
merged 8 commits into
ggerganov:master
from
teleprint-me:fix-vulkan-shader-warnings
Jul 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add prototypes for function definitions * Invert logic of --no-clean option to be more intuitive * Provide a new help prompt with clear instructions
teleprint-me
changed the title
chore: Fix compiler warnings, add help text, improve CLI options
chore: Fix vulkan related compiler warnings, add help text, improve CLI options
Jul 14, 2024
teleprint-me
changed the title
chore: Fix vulkan related compiler warnings, add help text, improve CLI options
Fix vulkan related compiler warnings, add help text, improve CLI options
Jul 14, 2024
teleprint-me
changed the title
Fix vulkan related compiler warnings, add help text, improve CLI options
chore : Fix vulkan related compiler warnings, add help text, improve CLI options
Jul 14, 2024
Signed-off-by: teleprint-me <77757836+teleprint-me@users.noreply.github.com>
I didn't notice that the binary wasn't ignored until afterwards. It's a minor quality of life change. Hopefully it's okay to bulk it in with this PR. |
mofosyne
added
the
Review Complexity : Low
Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
label
Jul 14, 2024
0cc4m
approved these changes
Jul 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor comments, looks good and works fine on Linux.
Co-authored-by: 0cc4m <picard12@live.de>
…llama.cpp into fix-vulkan-shader-warnings
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Aug 2, 2024
…CLI options (ggerganov#8477) * chore: Fix compiler warnings, add help text, improve CLI options * Add prototypes for function definitions * Invert logic of --no-clean option to be more intuitive * Provide a new help prompt with clear instructions * chore : Add ignore rule for vulkan shader generator Signed-off-by: teleprint-me <77757836+teleprint-me@users.noreply.github.com> * Update ggml/src/vulkan-shaders/vulkan-shaders-gen.cpp Co-authored-by: 0cc4m <picard12@live.de> * chore : Remove void and apply C++ style empty parameters * chore : Remove void and apply C++ style empty parameters --------- Signed-off-by: teleprint-me <77757836+teleprint-me@users.noreply.github.com> Co-authored-by: 0cc4m <picard12@live.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Review Complexity : Low
Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix vulkan related compiler warnings, add help text, improve CLI options
Overview
Details
This PR addresses several issues related to the CLI tool for generating Vulkan shaders. The main changes include adding prototypes for function definitions, inverting the logic of the
--no-clean
option, and providing a new help prompt with clear instructions on how to use the tool effectively.Notes
The addition of prototypes ensures that there are no undefined references during compilation. Inverting the logic of the --no-clean option makes it more intuitive for users to specify whether or not they want to remove temporary files after building. The new help prompt provides clear instructions on how to use the tool, making it easier for others to adopt and understand its capabilities.
Summary
I've tested this PR locally and ensured that all changes are functional and do not introduce any regressions in existing functionality.
Please review my changes and let me know if there are any questions or concerns before merging!