nix: remove nixConfig from flake.nix #4984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? I've demoed `nix run ggerganov/llama.cpp` to three people now, and the prompts caused by this setting have been a fly in the ointment every time, where I have to hand-wave away what's being asked... and because it happens on every single command run, it's a major pain in the ass. It's fine to leave it in the flake for those who read it, but the Nix ecosystem isn't yet ready to have flakes with nixConfig, in my judgement.
SomeoneSerge
approved these changes
Jan 16, 2024
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Feb 3, 2024
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? I've demoed
nix run ggerganov/llama.cppto three people now, and the prompts caused by this setting have been a fly in the ointment every time, where I have to hand-wave away what's being asked... and because it happens on every single command run, it's a major pain in the ass.It's fine to leave it in the flake for those who read it, but the Nix ecosystem isn't yet ready to have flakes with nixConfig, in my judgement.