Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Existing examples refactoring opportunities #7559

Open
3 tasks
mofosyne opened this issue May 27, 2024 · 0 comments
Open
3 tasks

Refactor: Existing examples refactoring opportunities #7559

mofosyne opened this issue May 27, 2024 · 0 comments
Labels
help wanted Extra attention is needed refactoring Refactoring

Comments

@mofosyne
Copy link
Collaborator

mofosyne commented May 27, 2024

GG in this PR was suggesting a refactoring of examples and provided an example of what he would like to refactor. This is a ticket to inform others about opportunities to improve examples

I think a bigger advantage would be to do some refactoring in the existing examples and "hide" some of the state for sampling and KV cache management that we expose behind the common API

If there is any other aspect of the example which is currently a pain point for developer grokking, feel free to also suggest some so it can be added here.

@mofosyne mofosyne added help wanted Extra attention is needed refactoring Refactoring labels May 27, 2024
@mofosyne mofosyne changed the title Refactor Existing Examples Refactor: Existing example refactoring opportunities May 27, 2024
@mofosyne mofosyne changed the title Refactor: Existing example refactoring opportunities Refactor: Existing examples refactoring opportunities May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed refactoring Refactoring
Projects
None yet
Development

No branches or pull requests

1 participant