Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Llava functions compiled as extern "C" throw exceptions #7073

Open
skoulik opened this issue May 4, 2024 · 0 comments
Open

Llava functions compiled as extern "C" throw exceptions #7073

skoulik opened this issue May 4, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@skoulik
Copy link

skoulik commented May 4, 2024

Basically this:
llama.cpp\examples\llava\clip.cpp(1277,13): warning : 'clip_model_load' has a non-throwing exception specification but can still throw [-Wexceptions]
llama.cpp\examples\llava\clip.cpp(2075,5): warning : 'clip_n_mmproj_embd' has a non-throwing exception specification but can still throw [-Wexceptions]

As these are library exported functions and wrapped in extern "C", they should not allow exceptions to cross the boundary. C language has no idea what to do with them.

Compiled with clang-cl in windows.

@slaren slaren added bug Something isn't working and removed bug-unconfirmed labels May 4, 2024
@slaren slaren changed the title Functions compiled as extern "C" throw exceptions Llava functions compiled as extern "C" throw exceptions May 4, 2024
@slaren slaren added the good first issue Good for newcomers label May 4, 2024
@Tejaakshaykumar Tejaakshaykumar mentioned this issue Sep 14, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants