Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there interest in a cuda implementation for ggml_conv_1d #788

Closed
balisujohn opened this issue Apr 5, 2024 · 3 comments
Closed

Is there interest in a cuda implementation for ggml_conv_1d #788

balisujohn opened this issue Apr 5, 2024 · 3 comments

Comments

@balisujohn
Copy link
Contributor

Unless I'm missing something ggml doesn't support it. It looks like I'm going to need it for tortoise.cpp. Is there interest in a cuda implementation for ggml_conv_1d being upstreamed into ggml?
@slaren
Copy link
Collaborator

slaren commented Apr 5, 2024

I think ggml_conv_1d is already supported in CUDA via im2col. Did you have any issues with it?

@balisujohn
Copy link
Contributor Author

ah, I'll look into that, and determine if there's features missing that I need.

@balisujohn
Copy link
Contributor Author

I ported to the newest version of ggml and the op worked correctly. Closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slaren @balisujohn