Skip to content

Conversation

@ErichDonGubler
Copy link
Member

No description provided.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one line got wrecked by CI.

@cwfitzgerald cwfitzgerald self-assigned this Nov 5, 2025
@DJMcNab
Copy link
Collaborator

DJMcNab commented Nov 5, 2025

To be consistent with the rest of intra-doc links, this only resolves associated items from traits that are in scope.

from rust-lang/rust#74489

So you might be able to make it work with:

#[cfg(doc)]
#[expect(unused_imports)]
use crate::Device;

in that file, else make the link be to crate::Device::map_buffer.

@ErichDonGubler ErichDonGubler force-pushed the erichdongubler-push-oblivious-tenacious-megalodon branch from b2b69c9 to 8e3607b Compare November 5, 2025 20:50
@ErichDonGubler
Copy link
Member Author

To be consistent with the rest of intra-doc links, this only resolves associated items from traits that are in scope.

from rust-lang/rust#74489

So you might be able to make it work with:

#[cfg(doc)]
#[expect(unused_imports)]
use crate::Device;

in that file, else make the link be to crate::Device::map_buffer.

I really like this suggestion! Since this is the first and only use of the trait, I'm worried about introducing an import that's not easy to detect as actually unused later. I ended up using [`Device::map_buffer`](crate::Device::map_buffer), but I'm going to have to remember this insight for later.

@ErichDonGubler ErichDonGubler enabled auto-merge (squash) November 5, 2025 20:51
@ErichDonGubler ErichDonGubler merged commit 9447a22 into gfx-rs:trunk Nov 5, 2025
41 checks passed
@ErichDonGubler ErichDonGubler deleted the erichdongubler-push-oblivious-tenacious-megalodon branch November 5, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants