[naga] Remove unused types and global expressions in a single pass #6934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
changed the title
jimblandy
changed the title
|
@kentslaney Does this look okay? 24aa5e2 (Those comments assume that #6976 will be merged.) (edit: it's merged now) |
|
@jimblandy LGTM, thank you |
|
@kentslaney Okay, two more commits, just minor tweaks. If those look all right, then I think this is ready to go. I'm so glad this idea worked out - thank you for giving it a shot! |
|
Confirmed with @kentslaney in chat that the two new commits look good. |
jimblandy
approved these changes
Jan 23, 2025
jimblandy
force-pushed
the
compact-leak-single-pass
branch
from
cd07fdd to
d06878d
Compare
In compaction, correctly identify unused types and global expressions, rather than treating all global expressions referred to by `PendingArraySize::Expression` array lengths as used even if the array type itself is not. This is tested by checking that going from expression to type and back, along with the opposite, is correctly marked as used. It also checks that adding an unused type using an expression gets compacted out. See the comments on `ModuleTracer::type_expression_tandem` for details. Fixes gfx-rs#6788.
jimblandy
force-pushed
the
compact-leak-single-pass
branch
from
d06878d to
b0aa1f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
closes #6788
alternative to #6806
Description
implements #6806 (comment)
Testing
This is tested by checking that going from expression to type and back, along with the opposite, is correctly marked as used. It also checks that adding an unused type using an expression gets compacted out.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.