Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metal: add the missing msg_send![view, retain] call within from_view #2976

Merged
merged 2 commits into from
Aug 20, 2022
Merged

metal: add the missing msg_send![view, retain] call within from_view #2976

merged 2 commits into from
Aug 20, 2022

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Aug 20, 2022 •
edited
Loading

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
#2974

Testing
Tested on macOS and iOS

jimblandy
jimblandy approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fast response!

@jimblandy jimblandy merged commit a08ea2a into gfx-rs:master Aug 20, 2022
@jrmuizel jrmuizel mentioned this pull request Aug 20, 2022
Closed
@jinleili jinleili deleted the mtl2 branch August 20, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinleili @jimblandy