added id32 feature #2464
Merged
added id32 feature #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With current code max values are: |
|
@kvark can you take a look? I didn't understand why rust complains if I don't specify repr(C) in 64bit case, and why deserialize fails... |
kvark
reviewed
Feb 10, 2022
|
Once we do these changes, the error will likely go away. It occurred because you had 2 definitions of |
caiiiycuk
force-pushed
the
wgpu-native-emscripten
branch
from
2a3640a
to
e72a728
Compare
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Related to gfx-rs/wgpu-native#171. Added feature to enable 32 bit ids.
Description
If you activate --features id32bits, then wgpu will generate 32 bits ids, and so wgpu-native can be used on 32bit systems like emscripten.
Testing
Added unit test to check corner cases.